Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabling high contrast dark theme on all platforms + hc-dark improvements #3184

Merged
merged 12 commits into from
Feb 22, 2016
Merged

Enabling high contrast dark theme on all platforms + hc-dark improvements #3184

merged 12 commits into from
Feb 22, 2016

Conversation

bgashler1
Copy link
Contributor

Addresses #2711

  • Enables the hc-dark theme on all platforms.
  • Improves color contrast to AAA standard on many elements that weren't previously meeting it.
  • Resolves visual bugs, such as synthetic-focus misplacement and action bar duplicate icons
  • Differentiates the selection of text from current line and find/word matching
  • Works well in Mac OSX even when OS-level accessibility features are enabled, such as increasing contrast.

NOTE:

A CSS rule used (mix-blend-mode: difference;) currently works in all browsers but Opera, IE and Edge, so it will not be ideal for the online Monaco editor without suitable shims. Let me know if we need to address this; we can do that now or in the future.

@bgashler1 bgashler1 added this to the Feb 2016 milestone Feb 19, 2016
@egamma egamma mentioned this pull request Feb 20, 2016
97 tasks
@joaomoreno joaomoreno mentioned this pull request Feb 22, 2016
3 tasks
alexdima added a commit that referenced this pull request Feb 22, 2016
Enabling high contrast dark theme on all platforms + hc-dark improvements
@alexdima alexdima merged commit b6ba8c1 into microsoft:master Feb 22, 2016
@alexdima
Copy link
Member

LGTM

@alexdima
Copy link
Member

@bgashler1 It is possible to write conditional browser selectors for ie or ff:

e.g.:

.monaco-editor.ff .inputarea,
.monaco-editor.ie .inputarea {
    width: 0;
    height: 0;
}

@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants