Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot commit merge commit when only my own changes are taken (no changed files) #99737

Closed
sanjom opened this issue Jun 10, 2020 · 3 comments
Closed

Comments

@sanjom
Copy link

sanjom commented Jun 10, 2020

  • VSCode Version: 1.45.1
  • OS Version: Linux x64 5.3.0-53-generic snap (Ubuntu 18.04)

Steps to Reproduce:

  1. In your code repository create a branch from master "test-branch" and make changes.
  2. In master branch, make changes that would produce a merge conflict.
  3. In "test-branch", use command line to "git merge master"
  4. Resolve the conflict, taking my own changes ("mine") in all cases. This leaves no file changes.
  5. Now I am unable to commit this merge commit using the VS Code UI, it works fine from the command line.

I assume the issue is, that since there are technically no changed files, this is not detected as a valid commit from the UI. However, since it is part of a merge process, committing should be possible.

Does this issue occur when all extensions are disabled?: Yes

@sanjom
Copy link
Author

sanjom commented Jun 10, 2020

I just found #88034. Seems to be the same issue

@sanjom
Copy link
Author

sanjom commented Jun 10, 2020

Also related: #7989

@sanjom sanjom closed this as completed Jun 10, 2020
@sanjom
Copy link
Author

sanjom commented Jun 10, 2020

Fixed by PR: #94021

@github-actions github-actions bot locked and limited conversation to collaborators Jul 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant