Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Same aria alert messages not re-read by screen readers #99466

Closed
isidorn opened this issue Jun 5, 2020 · 6 comments
Closed

Same aria alert messages not re-read by screen readers #99466

isidorn opened this issue Jun 5, 2020 · 6 comments
Assignees
Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Milestone

Comments

@isidorn
Copy link
Contributor

isidorn commented Jun 5, 2020

Currently when we do an alert we actually change the content of a hidden live region element.
Screen reader detects this and reads the new content.

However if we want the same alert to be re-read nothing happens.
Maybe we could have two hidden aria elements and change focus on them if there is a same message.

fyi @joanmarie for ideas

@isidorn isidorn added accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues under-discussion Issue is under discussion for relevance, priority, approach labels Jun 5, 2020
@isidorn isidorn added this to the June 2020 milestone Jun 5, 2020
@isidorn isidorn self-assigned this Jun 5, 2020
@joanmarie
Copy link

@isidorn: It this the case for all screen readers, or mainly just event-spam-afraid Orca? :)

Also: Is this something I can reproduce locally now?

@isidorn
Copy link
Contributor Author

isidorn commented Jun 8, 2020

@joanmarie this is the case for all screen readers
Easy repro steps:

  1. Open Explorer view
  2. Click on the new file action
  3. In the input type something and delete it, hear alert "A file or folder name must be provided"
  4. Repeat step 3, nothing gets read

I will experiment with another hidden element.

@joanmarie
Copy link

So this seems to be the same issue I mentioned in #95961 (comment). If we had a stand-alone test case, that would be helpful.

@isidorn
Copy link
Contributor Author

isidorn commented Jun 9, 2020

@joanmarie thanks for looking into it. I will look into a workaround / stand-alone sample.

@isidorn isidorn added bug Issue identified by VS Code Team member as probable bug and removed under-discussion Issue is under discussion for relevance, priority, approach labels Jun 17, 2020
@isidorn
Copy link
Contributor Author

isidorn commented Jun 17, 2020

@joanmarie did a workaround by having alternative containers so if a same message gets set we set on the alternate one so this seems fixed in vscode.
For the standalone, it should look something like this https://jsfiddle.net/Lfk1m4oh/1/
Though I did not verify if this works, just sketched it up

@isidorn
Copy link
Contributor Author

isidorn commented Jun 17, 2020

Verifier: turn on NVDA on Orca
Explorer > new file > type something then delete it -> make sure the error that a name must be provided is read out
Do this again and make sure the errors is read out.

@bpasero bpasero added the verified Verification succeeded label Jul 3, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Aug 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

4 participants
@bpasero @isidorn @joanmarie and others