Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings sync -LocalTooManyRequests (UserDataSyncError) undefined: Too many requests. #99100

Closed
lszomoru opened this issue Jun 2, 2020 · 1 comment
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders settings-sync verified Verification succeeded
Milestone

Comments

@lszomoru
Copy link
Member

lszomoru commented Jun 2, 2020

Testing #98962

When the LocalTooManyRequests occurs we are writing an undefined object into the logs.

_

[2020-06-02 15:56:57.315] [userDataSync] [error] LocalTooManyRequests (UserDataSyncError) undefined: Too many requests. Allowed only 100 requests in 5 minutes.
at w.request (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/code/electron-browser/sharedProcess/sharedProcessMain.js:527:747)
at e.request (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/code/electron-browser/sharedProcess/sharedProcessMain.js:525:102)
at async e.manifest (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/code/electron-browser/sharedProcess/sharedProcessMain.js:523:528)
at async e.doSync (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/code/electron-browser/sharedProcess/sharedProcessMain.js:514:300)

_

@lszomoru lszomoru added the bug Issue identified by VS Code Team member as probable bug label Jun 2, 2020
@lszomoru lszomoru added this to the May 2020 milestone Jun 2, 2020
@sandy081
Copy link
Member

sandy081 commented Jun 2, 2020

Good catch

@lszomoru lszomoru added the verified Verification succeeded label Jun 4, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Jul 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders settings-sync verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

4 participants
@Tyriar @lszomoru @sandy081 and others