Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings sync - display error message when expanding nodes in the Synched data panel #99082

Closed
lszomoru opened this issue Jun 2, 2020 · 1 comment
Assignees
Labels
insiders-released Patch has been released in VS Code Insiders polish Cleanup and polish issue settings-sync
Milestone

Comments

@lszomoru
Copy link
Member

lszomoru commented Jun 2, 2020

Testing #98962

When disconnecting from the network, then I try to expand any of the nodes in the Synched data panel nothing is happening. We should improve our error handling so that an error is being displayed when trying to expand the nodes. We might also want to cache some of that information locally so that we do not always call the service to get it.

@lszomoru lszomoru added this to the May 2020 milestone Jun 2, 2020
@lszomoru lszomoru added the bug Issue identified by VS Code Team member as probable bug label Jun 2, 2020
@sandy081
Copy link
Member

sandy081 commented Jun 2, 2020

Accepting this request for handling errors, but for caching - I see how it is helpful but since this feature (synced data views) is not a prominent feature and not much worth the value to provide this.

@sandy081 sandy081 added polish Cleanup and polish issue and removed bug Issue identified by VS Code Team member as probable bug labels Jun 2, 2020
@sandy081 sandy081 modified the milestones: May 2020, Backlog Jun 2, 2020
@sandy081 sandy081 modified the milestones: Backlog, May 2020 Jun 3, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Jul 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
insiders-released Patch has been released in VS Code Insiders polish Cleanup and polish issue settings-sync
Projects
None yet
Development

No branches or pull requests

3 participants
@lszomoru @sandy081 and others