Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Settings sync - I am able to enter spaces as the machine name #99079

Closed
lszomoru opened this issue Jun 2, 2020 · 0 comments
Closed

Settings sync - I am able to enter spaces as the machine name #99079

lszomoru opened this issue Jun 2, 2020 · 0 comments
Assignees
@sandy081
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders settings-sync verified Verification succeeded
Milestone
May 2020

Comments

@lszomoru
Copy link
Member

lszomoru commented Jun 2, 2020 •
edited by sandy081
Loading

Testing #98962

Validate the input string for the machine name:

  • Trim the machine name input
  • Also do some validation about entering all spaces
  • We should show an error if one is trying to specify a machine name that already exists
@lszomoru lszomoru added the bug Issue identified by VS Code Team member as probable bug label Jun 2, 2020
@lszomoru lszomoru added this to the May 2020 milestone Jun 2, 2020
@sandy081 sandy081 mentioned this issue Jun 2, 2020
Closed
@lszomoru lszomoru added the verified Verification succeeded label Jun 4, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Jul 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@sandy081 sandy081

Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders settings-sync verified Verification succeeded
Projects
None yet
Milestone
May 2020
Development

No branches or pull requests
3 participants
@lszomoru @sandy081 and others