Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Up and down arrows work on shell history and the IME proposal window at the same time. #9817

Closed
kieferrm opened this issue Jul 26, 2016 · 4 comments
Closed

Up and down arrows work on shell history and the IME proposal window at the same time. #9817

kieferrm opened this issue Jul 26, 2016 · 4 comments
Assignees
@Tyriar
Labels
l10n-platform Localization platform issues (not wrong translations) terminal General terminal issues that don't fall under another label upstream Issue identified as 'upstream' component related (exists outside of VS Code)

Comments

@kieferrm
Copy link
Member

Testing #9695 on MacOS:

Disclaimer: I don't really know what I'm using IME, I don't speak any of those languages.

Steps to reproduce:

  1. Configure your keyboard:

screen shot 2016-07-26 at 3 36 00 pm

  1. See screen recording: I'm typing a rather random sequence of key strokes and sometimes select another proposal using the down arrow followed by space to insert it.

  2. When the selection is at the top of the proposal window and I type up arrow the shell goes back in history. This might or might not be the right thing. Press the up arrow a few times.

  3. Pressing the down arrow now changes the selection in the proposal window as well as scrolling forward in the shell's history. This doesn't seem right.

fdqrx1tpju
@kieferrm
Copy link
Member Author

On further contemplation: The scrolling only happens on character boundaries, i.e. after having hit space for committing a character and while in a character composition. So, this might or might not be the intended behavior.

@kieferrm kieferrm added terminal General terminal issues that don't fall under another label l10n-platform Localization platform issues (not wrong translations) labels Jul 27, 2016
@Tyriar Tyriar added the upstream Issue identified as 'upstream' component related (exists outside of VS Code) label Jul 27, 2016
@Tyriar Tyriar added this to the August 2016 milestone Jul 27, 2016
@Tyriar
Copy link
Member

Tyriar commented Jul 27, 2016

Marking for August as it's non-critical and an upstream issue.

@Tyriar
Copy link
Member

Tyriar commented Jul 27, 2016 •
edited
Loading

Doesn't actually reproduce on Ubuntu using ibus hangul - given this it might be a problem with the Mac IME.

@Tyriar
Copy link
Member

Tyriar commented Aug 8, 2016

Closing as designed as it only happens on Mac meaning the IME itself is allowing it to happen.

@Tyriar Tyriar closed this as completed Aug 8, 2016
@Tyriar Tyriar removed this from the August 2016 milestone Aug 8, 2016
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

Labels
l10n-platform Localization platform issues (not wrong translations) terminal General terminal issues that don't fall under another label upstream Issue identified as 'upstream' component related (exists outside of VS Code)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Tyriar @kieferrm