Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[terminal] Copy action enabled on empty selection, but copy doesn't work #9743

Closed
aeschli opened this issue Jul 26, 2016 · 1 comment
Closed

[terminal] Copy action enabled on empty selection, but copy doesn't work #9743

aeschli opened this issue Jul 26, 2016 · 1 comment
Assignees
@Tyriar
Labels
bug Issue identified by VS Code Team member as probable bug terminal General terminal issues that don't fall under another label verified Verification succeeded
Milestone
April 2017

Comments

@aeschli
Copy link
Contributor

aeschli commented Jul 26, 2016

Testing #9723

Linux, Elementary OS

  • Open the terminal
  • select some text in the terminal, use copy from the context menu, paste the text: works
  • set the focus to the cursor position (no selection), use copy from the context menu, paste the text: still pastes the previous text

-> Maybe the copy menu should not be present (or disabled) if the selection is empty
@Tyriar Tyriar added this to the Backlog milestone Jul 27, 2016
@Tyriar Tyriar added terminal General terminal issues that don't fall under another label ux User experience issues labels Jul 27, 2016
@Tyriar Tyriar modified the milestones: August 2016, Backlog Jul 27, 2016
@stevencl
Copy link
Member

stevencl commented Aug 2, 2016

Another option would be to copy the whole line if there is no selection like we do in the editor?

@Tyriar Tyriar modified the milestones: Backlog, August 2016 Aug 10, 2016
@Tyriar Tyriar modified the milestones: April 2017, Backlog Apr 3, 2017
@Tyriar Tyriar added bug Issue identified by VS Code Team member as probable bug and removed ux User experience issues labels Apr 3, 2017
@Tyriar Tyriar closed this as completed in 45ab972 Apr 3, 2017
@Tyriar Tyriar added the verified Verification succeeded label Apr 27, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

Labels
bug Issue identified by VS Code Team member as probable bug terminal General terminal issues that don't fall under another label verified Verification succeeded
Projects
None yet
Milestone
April 2017
Development

No branches or pull requests
3 participants
@stevencl @Tyriar @aeschli