Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow goToSymbol via copy pasted path #96651

Closed
ackvf opened this issue Apr 29, 2020 · 2 comments
Closed

Allow goToSymbol via copy pasted path #96651

ackvf opened this issue Apr 29, 2020 · 2 comments
Assignees
Labels
typescript Typescript support issues upstream-issue-linked This is an upstream issue that has been reported upstream

Comments

@ackvf
Copy link

ackvf commented Apr 29, 2020

Our code comments sometimes mention symbols in other files. I want to be able to copy such a path LayoutEditor.tsx@acceptsChildren and paste it into goToSymbol field like this:

vscode-go-to-symbol

However, it doesn't work currently and needs to be done in two steps.

@mjbvz
Copy link
Collaborator

mjbvz commented Apr 30, 2020

Seems to me that ideally that symbol in the comment should just be clickable. That falls under microsoft/TypeScript#35524

@mjbvz mjbvz closed this as completed Apr 30, 2020
@mjbvz mjbvz added the upstream-issue-linked This is an upstream issue that has been reported upstream label Apr 30, 2020
@mjbvz mjbvz self-assigned this Apr 30, 2020
@mjbvz mjbvz added the typescript Typescript support issues label Apr 30, 2020
@ackvf
Copy link
Author

ackvf commented Apr 30, 2020

@mjbvz That comment is not actually a jsdoc and we don't use @see in that instance. But if it were supported by jsdoc, we might consider switching over.

Though, the copy/paste is generally useful as I also sometimes share these symbol links via instant messaging with colleagues.

@github-actions github-actions bot locked and limited conversation to collaborators Jun 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
typescript Typescript support issues upstream-issue-linked This is an upstream issue that has been reported upstream
Projects
None yet
Development

No branches or pull requests

2 participants