Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Autoclosing pairs for PowerShell herestrings #95244

Closed
TylerLeonhardt opened this issue Apr 14, 2020 · 0 comments · Fixed by #95245
Closed

Add Autoclosing pairs for PowerShell herestrings #95244

TylerLeonhardt opened this issue Apr 14, 2020 · 0 comments · Fixed by #95245
Assignees
@alexdima
Labels
feature-request Request for new features or functionality languages-basic Basic language support issues verification-needed Verification of issue is requested verified Verification succeeded
Milestone
April 2020

Comments

@TylerLeonhardt
Copy link
Member

I'll have a PR out for this in a sec. Wanted to get an issue tracking it.

$str = @"
I am a here string
"@

$str = @'
I am also a here string
'@

These @''@ and @""@ should autoclose.

NOTE: PowerShell syntax says that the here string open (@') should be the last characters on a line so we should include a newline in the close.
@TylerLeonhardt TylerLeonhardt mentioned this issue Apr 14, 2020
Merged
@alexdima alexdima added feature-request Request for new features or functionality languages-basic Basic language support issues labels Apr 14, 2020
@alexdima alexdima added this to the April 2020 milestone Apr 14, 2020
@alexdima alexdima self-assigned this Apr 14, 2020
@alexdima alexdima added the verification-needed Verification of issue is requested label Apr 28, 2020
@jrieken jrieken added the verified Verification succeeded label Apr 28, 2020
@github-actions github-actions bot locked and limited conversation to collaborators May 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@alexdima alexdima

Labels
feature-request Request for new features or functionality languages-basic Basic language support issues verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Milestone
April 2020
Development

Successfully merging a pull request may close this issue.

Add PowerShell herestring autoclosing pairs TylerLeonhardt/vscode
3 participants
@jrieken @TylerLeonhardt @alexdima