Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vscode not killing child processes #948

Closed
ghost opened this issue Dec 3, 2015 · 4 comments
Closed

vscode not killing child processes #948

ghost opened this issue Dec 3, 2015 · 4 comments
Assignees
Labels
on-testplan verified Verification succeeded
Milestone

Comments

@ghost
Copy link

ghost commented Dec 3, 2015

when you do child_process.spawn, the new process is a child of Code, but when Code quit the children process do not, is this intended?

@alexdima
Copy link
Member

alexdima commented Dec 3, 2015

@azumikav are you spawning processes from an extension?

@alexdima alexdima self-assigned this Dec 3, 2015
@ghost
Copy link
Author

ghost commented Dec 3, 2015

yes.

@alexdima
Copy link
Member

alexdima commented Dec 4, 2015

@azumikav The right think to do here is for VSCode to call deactivate on extensions on shutdown and for extensions to clean up on shutdown.

@alexdima alexdima added this to the Dec 2015 milestone Dec 4, 2015
@egamma egamma mentioned this issue Dec 4, 2015
34 tasks
@alexdima
Copy link
Member

alexdima commented Dec 9, 2015

With 98473e0, VSCode's extension host will now call deactivate() if extensions export it and call dispose() on ExtensionContext.subscriptions on shutdown, then will wait 1s before exiting

@alexdima alexdima closed this as completed Dec 9, 2015
@egamma egamma mentioned this issue Jan 6, 2016
59 tasks
@alexdima alexdima added the verified Verification succeeded label May 27, 2016
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
on-testplan verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

2 participants