-
Notifications
You must be signed in to change notification settings - Fork 30.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Debug console suggestions should not fuzzy match on history entries #91617
Comments
These are items from the history. Imo though we should probably prefix search on the history like the Chrome debug console does, rather than fuzzy search--complex history expressions will probably always have some undesirable fuzzy match against lots of inputs. May also help with #90520. Thoughts @isidorn ? |
I think the more important issue here, is why didn't I get real completion for the object itself? |
Can you share the code that you were paused in or a wider screenshot? Did it show up in the variables pane? |
@connor4312 your idea makes sense, however the suggestWidget deos not support different matching styles on different suggestions. As far as I know @jrieken |
I can repro with a very simple sample: const http = require("http");
const hostname = "127.0.0.1";
const port = process.env.PORT === undefined ? 8080 : process.env.PORT;
function setup() {
const server = http.createServer((req, res) => {
res.statusCode = 200;
res.setHeader("Content-Type", "text/plain");
res.end("Hello World!\n");
});
server.listen(port, hostname, () => {
console.log(`Server running at http://${hostname}:${port}/`);
});
}
setup(); If you set a breakpoint in the |
Okay, there's two issues here--completions not showing and items from the history showing when they probably should not. I'll reopen an issue for the former in js-debug's repo. |
In the image below the
itemsMap
variable is aMap
, but it doesn't even seem to be seen as an object at all.The text was updated successfully, but these errors were encountered: