Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debug console suggestions should not fuzzy match on history entries #91617

Closed
eamodio opened this issue Feb 26, 2020 · 7 comments
Closed

Debug console suggestions should not fuzzy match on history entries #91617

eamodio opened this issue Feb 26, 2020 · 7 comments
Assignees
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues feature-request Request for new features or functionality *out-of-scope Posted issue is not in scope of VS Code
Milestone

Comments

@eamodio
Copy link
Contributor

eamodio commented Feb 26, 2020

In the image below the itemsMap variable is a Map, but it doesn't even seem to be seen as an object at all.

image

@connor4312
Copy link
Member

connor4312 commented Feb 26, 2020

These are items from the history. Imo though we should probably prefix search on the history like the Chrome debug console does, rather than fuzzy search--complex history expressions will probably always have some undesirable fuzzy match against lots of inputs. May also help with #90520. Thoughts @isidorn ?

@connor4312 connor4312 transferred this issue from microsoft/vscode-js-debug Feb 26, 2020
@connor4312 connor4312 added the debug Debug viewlet, configurations, breakpoints, adapter issues label Feb 26, 2020
@eamodio
Copy link
Contributor Author

eamodio commented Feb 26, 2020

I think the more important issue here, is why didn't I get real completion for the object itself?

@roblourens
Copy link
Member

Can you share the code that you were paused in or a wider screenshot? Did it show up in the variables pane?

@roblourens roblourens added the info-needed Issue requires more information from poster label Feb 27, 2020
@isidorn
Copy link
Contributor

isidorn commented Feb 27, 2020

@connor4312 your idea makes sense, however the suggestWidget deos not support different matching styles on different suggestions. As far as I know @jrieken
We always fuzzy match

@eamodio
Copy link
Contributor Author

eamodio commented Feb 27, 2020

I can repro with a very simple sample:

const http = require("http");

const hostname = "127.0.0.1";
const port = process.env.PORT === undefined ? 8080 : process.env.PORT;

function setup() {
  const server = http.createServer((req, res) => {
    res.statusCode = 200;
    res.setHeader("Content-Type", "text/plain");
    res.end("Hello World!\n");
  });

  server.listen(port, hostname, () => {
    console.log(`Server running at http://${hostname}:${port}/`);
  });
}

setup();

If you set a breakpoint in the createServer lambda and then type res. in the Debug Console there will be no completion. But res does show up in the locals

@connor4312
Copy link
Member

Okay, there's two issues here--completions not showing and items from the history showing when they probably should not. I'll reopen an issue for the former in js-debug's repo.

@isidorn isidorn changed the title Completion list sometimes doesn't have valid completions Debug console suggestions should not fuzzy match on history entries Mar 2, 2020
@isidorn isidorn added feature-request Request for new features or functionality and removed info-needed Issue requires more information from poster labels Mar 2, 2020
@isidorn isidorn added this to the Backlog milestone Mar 2, 2020
@rebornix rebornix added the verified Verification succeeded label Apr 1, 2020
@isidorn isidorn removed the verified Verification succeeded label Jun 9, 2020
@isidorn isidorn added the *out-of-scope Posted issue is not in scope of VS Code label Nov 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues feature-request Request for new features or functionality *out-of-scope Posted issue is not in scope of VS Code
Projects
None yet
Development

No branches or pull requests

6 participants
@roblourens @eamodio @rebornix @isidorn @connor4312 and others