Integrated Terminal can not display and input Chinese word

[archer-trek]

• VSCode Version: 1.3.0
• OS Version: OS X EI Capitan 10.11.5

Can not display

Steps to Reproduce:

1. Create a directory or file with Chinese word.
2. Open terminal in vscode and execute ls command.

ITerm2

VSCode Terminal

Can not input

Steps to Reproduce:

1. Open ternimal in vscode.
2. Input some Chinese word with system default Chinese IME.

[ZCShou]

Can Display but can not input on Windows 10!

[Tyriar]

@wzyplus this is related to the font, do you have a custom font set for the terminal? The editor's font should be the fallback which is expected to work.

@ZCShou see #7045

[ZCShou]

@Tyriar font set for the terminal is default,but IME is not

[archer-trek]

@Tyriar No, I didn't change the font of the terminal. But changed the editor's font to Consolas.

[Tyriar]

@wzyplus Does the problem go away if you use the default editor.fontFamily fallbacks?

"editor.fontFamily": "Consolas, 'Droid Sans Mono', 'Courier New', monospace, 'Droid Sans Fallback'"

[archer-trek]

@Tyriar No, it doesn't work.

[Tyriar]

@wzyplus can you setup xterm.js and see if you can reproduce it in the demo?

git clone https://github.com/sourcelair/xterm.js.git
cd xterm.js
npm install
npm start
# navigate to http://0.0.0.0:3000

[archer-trek]

@Tyriar Can display but can't input.

[Tyriar]

@wzyplus can you try toggling dev tools on vscode (Help > Toggle Developer Tools), inspecting the span/div containing the ?????? (using cursor button in top-left corner of dev tools) and get the paste in both the contents of the element and the computed font-family style?

Inspect button:

Computed styles tab:

[archer-trek]

@Tyriar

[ZCShou]

@Tyriar So does on Win10! But The lastest version can copy & paste！I have a .gif file, but upload failed！

[Tyriar]

FYI on the input side of things I've put out a PR which is mostly done, I still need to verify it on multiple-character IME compositions though, such as in Japanese. I'm not familiar with the Chinese IME systems but I think it's likely covered by the Korean/Japanese cases. xtermjs/xterm.js#175

This should hopefully land in Insiders in about a week.

[alexdima]

@Tyriar Here is a wiki page I put together from various sources with examples and detailed steps on how different input methods should work, considering Word as the golden standard: https://github.com/Microsoft/vscode/wiki/IME-Test

[Tyriar]

@alexandrudima I think this issue is related to text encoding rather than the IME.

I'm familiar with Japanese and Korean IMEs from language learning so I used that experience when implementing support (which is in stable now). @rebornix did tests for Chinese, I don't think Vietnamese was tested though. You can check out xtermjs/xterm.js#175 for the testing I did before endgame.

Thanks for the resource 👍

[yangg]

vs code: 1.6.0
Can not display Chinese character in git log on windows 7,
but it displays folder with Chinese character correctly.
I tried both cmd.exe & git bash.exe

"terminal.integrated.shell.windows": "bash.exe", // git bash

[Tyriar]

The situation for this should be better now as $LANG is being set.