Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Very difficult to find file's path with tabs #8501

Closed
alexdima opened this issue Jun 29, 2016 · 12 comments
Closed

Very difficult to find file's path with tabs #8501

alexdima opened this issue Jun 29, 2016 · 12 comments
Assignees
Labels
ux User experience issues workbench-tabs VS Code editor tab issues

Comments

@alexdima
Copy link
Member

Testing #7854

  1. the hover takes very long to show (maybe this hover can be made faster?)
  2. I need to hover over the text and not over the tab area
@alexdima alexdima changed the title Very difficult to find file's path Very difficult to find file's path with tabs Jun 29, 2016
@bpasero bpasero added workbench-tabs VS Code editor tab issues ux User experience issues labels Jun 29, 2016
@bpasero bpasero assigned stevencl and bgashler1 and unassigned bpasero Jun 29, 2016
@bgashler1
Copy link
Contributor

bgashler1 commented Jun 29, 2016

I like your point @alexandrudima about making hover on the whole tab. I, too, found it a little awkward because I had to hit the right target, and it's not clear where the text's vertical boundaries are. @bpasero is this doable?

As far as the timing, how about we first make that hover change and see if that fixes the pain? It may no longer be an issue since the hover target will be so easy to hit accurately. I worry decreasing the delay with such a large hover area may make this hover tip appear more than is desirable.

@Tyriar
Copy link
Member

Tyriar commented Jun 30, 2016

I raised this earlier here #7960, wanting to be able to get at the path using just the keyboard.

@bpasero
Copy link
Member

bpasero commented Jun 30, 2016

The hover is native and the timing cannot be changed. Introducing a custom hover is possible but we do this nowhere else. I have no good solution for this other than suggesting to disable tabs if you really need the path to be visible.

@bpasero
Copy link
Member

bpasero commented Jul 2, 2016

There is actually an extension that just puts the full path of the file to the status bar: https://marketplace.visualstudio.com/items?itemName=RoscoP.ActiveFileInStatusBar

image

@Tyriar
Copy link
Member

Tyriar commented Jul 2, 2016

@bpasero that's good enough for me 👍

@stevencl
Copy link
Member

stevencl commented Jul 4, 2016

That seems like a fine solution. In fact, I was convinced that we had designed that in our original mockups but it turns out we didn't. We should consider just doing this I think.

@bpasero
Copy link
Member

bpasero commented Jul 4, 2016

I like to keep this up for an extension, if we did this out of the box, many people might find it annoying and ask for a way to disable.

@stevencl
Copy link
Member

stevencl commented Jul 4, 2016

If this turns out to be a problem for only a few people then I'm fine with an extension. But if this turns out to be a problem for a large number of people then we really should reconsider and figure out how to solve this out of the box.

@stevencl stevencl closed this as completed Jul 4, 2016
@bpasero
Copy link
Member

bpasero commented Jul 4, 2016

Btw I still think we should maybe look into a custom hover if the native hover is so hard to be used. But we can leave this closed until we get more feedback from users once June is out 👍

@alexdima
Copy link
Member Author

alexdima commented Jul 4, 2016

How does this extension target my specific two points above:

  1. the hover takes very long to show (maybe this hover can be made faster?)
  2. I need to hover over the text and not over the tab area

I understand point 1 is non-trivial as we now use the native hover.
How about point 2? Isn't that a low hanging fix?

@bpasero
Copy link
Member

bpasero commented Jul 4, 2016

@alexandrudima sorry, those are good points, I will open a separate issue on the hover thing.

@alexdima
Copy link
Member Author

alexdima commented Jul 4, 2016

@bpasero thank you 👍

@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
ux User experience issues workbench-tabs VS Code editor tab issues
Projects
None yet
Development

No branches or pull requests

5 participants