Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot open tab's context menu (e.g. go to next diff) with keyboard #8500

Closed
alexdima opened this issue Jun 29, 2016 · 9 comments
Closed

Cannot open tab's context menu (e.g. go to next diff) with keyboard #8500

alexdima opened this issue Jun 29, 2016 · 9 comments
Assignees
Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues bug Issue identified by VS Code Team member as probable bug verified Verification succeeded workbench-tabs VS Code editor tab issues
Milestone

Comments

@alexdima
Copy link
Member

alexdima commented Jun 29, 2016

Testing #7854

I tried moving focus to a tab and pressing shift-f10.

You need to listen for Shift+F10 and bring up the context menu (e.g. tree widget also does it.)

@alexdima alexdima added the accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues label Jun 29, 2016
@bpasero bpasero added bug Issue identified by VS Code Team member as probable bug workbench-tabs VS Code editor tab issues labels Jun 29, 2016
@bpasero bpasero added this to the June 2016 milestone Jun 29, 2016
@bpasero
Copy link
Member

bpasero commented Jun 29, 2016

@alexandrudima works for me when using "on screen keyboard" pressing the context menu key:

image

I do not know about Shift+F10.

@bpasero bpasero added the info-needed Issue requires more information from poster label Jun 29, 2016
@bpasero bpasero modified the milestones: Backlog, June 2016 Jun 29, 2016
@bpasero
Copy link
Member

bpasero commented Jun 29, 2016

All I have is a context menu event handler on the DIV that is the tab, so I am not sure what else I need to do.

@bpasero
Copy link
Member

bpasero commented Jun 29, 2016

Actually Shift+F10 also works for me, just tried.

@alexdima
Copy link
Member Author

@bpasero The context menu key works for me too. Under Windows, I think it is expected that Shift+F10 also opens the context menu. Maybe for keyboards without a context menu key?

AFAIK that needs a manual listener. i.e.:

{ "key": "shift+f10",             "command": "editor.action.showContextMenu",
                                     "when": "editorTextFocus" },

@bpasero
Copy link
Member

bpasero commented Jun 29, 2016

@alexandrudima for me it just works, when I press Shift+F10 on a tab that has focus (with blue outline) I get the menu. Weird that you are not?

@bpasero
Copy link
Member

bpasero commented Jun 29, 2016

Even on my thinkpad without VM and without the context menu key.

@alexdima
Copy link
Member Author

Yeah, I don't get it, I just tried dev, in case I missed a commit. I don't get contextmenu on Win10. Maybe we can ask @dbaeumer to try.

@dbaeumer If you focus your way to a tab title, does shift-f10 show the contextmenu for you?

@dbaeumer
Copy link
Member

Yes it does

capture

@alexdima
Copy link
Member Author

@bpasero I can show on my machine

@bpasero bpasero modified the milestones: June 2016, Backlog Jun 30, 2016
@bpasero bpasero removed the info-needed Issue requires more information from poster label Jul 1, 2016
@bpasero bpasero modified the milestones: July 2016, June 2016 Jul 1, 2016
@bpasero bpasero closed this as completed in 3d2ece9 Jul 4, 2016
@jrieken jrieken added the verified Verification succeeded label Jul 28, 2016
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues bug Issue identified by VS Code Team member as probable bug verified Verification succeeded workbench-tabs VS Code editor tab issues
Projects
None yet
Development

No branches or pull requests

4 participants