Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

preLaunchTask on workspace configuration doesn't work #83992

Closed
alexr00 opened this issue Nov 5, 2019 · 2 comments
Closed

preLaunchTask on workspace configuration doesn't work #83992

alexr00 opened this issue Nov 5, 2019 · 2 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues verified Verification succeeded
Milestone

Comments

@alexr00
Copy link
Member

alexr00 commented Nov 5, 2019

From some discussion in #83065

workspace file:

	"tasks": {
		"version": "2.0.0",
		"tasks": [
			{
				"label": "My Task",
				"type": "shell",
				"command": "dir",
				"problemMatcher": []
			},
		]
	},
	"launch": {
		"configurations": [
			{
				"type": "node",
				"request": "attach",
				"name": "Attach",
				"port": 9229,
				"skipFiles": [
					"<node_internals>/**"
				],
				"preLaunchTask": "My Task" // Does not work
			}
		],
		"compounds": [
			{
				"name": "Compound",
				"configurations": ["Attach"],
				"preLaunchTask": "My Task" // Works great
			}
		]
	}
@alexr00 alexr00 mentioned this issue Nov 5, 2019
2 tasks
@weinand weinand added debug Debug viewlet, configurations, breakpoints, adapter issues bug Issue identified by VS Code Team member as probable bug labels Nov 5, 2019
@weinand weinand added this to the November 2019 milestone Nov 5, 2019
@isidorn
Copy link
Contributor

isidorn commented Dec 5, 2019

This was never working, thus pushing to next milestone to fix then and not takcle as part of endgame.

@isidorn
Copy link
Contributor

isidorn commented Dec 24, 2019

@alexr00 thanks for the nice steps, I have pushed a fix for this. Try it out and let me know how it behaves for you. I verified with your sample and it looks fixed for me.

@connor4312 connor4312 added the verified Verification succeeded label Jan 30, 2020
@vscodebot vscodebot bot locked and limited conversation to collaborators Feb 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

4 participants