Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Monaco Editor / CSS: Intellisense for variables is not using 'var' #8345

Closed
sandy081 opened this issue Jun 28, 2016 · 3 comments
Closed

Monaco Editor / CSS: Intellisense for variables is not using 'var' #8345

sandy081 opened this issue Jun 28, 2016 · 3 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug css-less-scss Issues and items concerning CSS,Less,SCSS styling verified Verification succeeded
Milestone

Comments

@sandy081
Copy link
Member

sandy081 commented Jun 28, 2016

#8229

Safari

Steps to Reproduce:
In Monaco Editor

  1. Change the Language to css
  2. Write a :root rule with a variable declaration
  3. In other rules, use Intellisense to select the above variable

Expected: Intellisense should set var(--variable)
Actual: Intellisense is placing let(--variable)

@sandy081 sandy081 added css-less-scss Issues and items concerning CSS,Less,SCSS styling monaco-editor labels Jun 28, 2016
@aeschli aeschli added this to the June 2016 milestone Jun 29, 2016
@aeschli
Copy link
Contributor

aeschli commented Jun 29, 2016

@aeschli aeschli closed this as completed Jun 29, 2016
@aeschli aeschli added the bug Issue identified by VS Code Team member as probable bug label Jun 30, 2016
@sandy081 sandy081 added the verified Verification succeeded label Jun 30, 2016
@sandy081
Copy link
Member Author

@aeschli Is not this fix yet available in monaco-editor here https://microsoft.github.io/monaco-editor/index.html

@aeschli
Copy link
Contributor

aeschli commented Jun 30, 2016

You have to test that in the all source mode (https://marketplace.visualstudio.com/items?itemName=ms-vscode.js-atom-grammar) or wait for all versions to be bumped. @alexandrudima should do that soon.

@alexandrudima I update all version number for monaco-css / -json and -languages and published these. I updated the dependencies monaco-editor to these, but did not increase the monaco-editor version nor did I publish. I leave this up to you.

@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug css-less-scss Issues and items concerning CSS,Less,SCSS styling verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

2 participants