Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiline find #8230

Closed
2 tasks done
alexdima opened this issue Jun 28, 2016 · 1 comment
Closed
2 tasks done

Multiline find #8230

alexdima opened this issue Jun 28, 2016 · 1 comment

Comments

@alexdima
Copy link
Member

alexdima commented Jun 28, 2016

You can test in any OS

If you turn on the regex checkbox in the find widget, you can now search for \r or \n. Please check cases with different end of line sequences (CRLF vs LF). Please check find prev, find next, replace next, replace all, etc individually (they point to different implementations).

It is unclear to me what to do with the find in selection, I have a feeling it is now too eagerly activating. Please let me know in issues how you feel about it.

@alexdima alexdima added this to the June 2016 milestone Jun 28, 2016
@dbaeumer
Copy link
Member

@alexandrudima I did the testing and I agree that the find in selection versus prepopulating the find box is now a little inconsistent. I would suggest the following:

  • if text is selected that spawns more than one line we still assume that the user wants to find in selection.
  • if he unchecks the FInd in Selection and didn't type and search text we can repopulate the search field with the selected text as a regular expression.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants