Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reload window resets terminal windows #82102

Closed
vandijkstef opened this issue Oct 8, 2019 · 3 comments
Closed

Reload window resets terminal windows #82102

vandijkstef opened this issue Oct 8, 2019 · 3 comments
Assignees
Labels
*duplicate Issue identified as a duplicate of another issue(s)

Comments

@vandijkstef
Copy link

When using the 'reload window' command, most windows and layout come back right as you left them, only terminal windows do not. Im not referring to reinstating the active process (I dont care about the running processes being killed), but just to the inner layout of the terminal tab, for example when you have 2 terminal windows open side by side. After the reload, you have just one terminal and have to open the second one manually. Would love to have the 2 windows side by side after the reload.

@Tyriar
Copy link
Member

Tyriar commented Oct 8, 2019

/duplicate #44302

@Tyriar Tyriar closed this as completed Oct 8, 2019
@vscodebot vscodebot bot added the *duplicate Issue identified as a duplicate of another issue(s) label Oct 8, 2019
@vandijkstef
Copy link
Author

#44302 is talking about "terminal process shell, args, env and layout". Im just talking about layout.
As I understand, just for the layout part we need to wait for #45407 before this can be done.

#44302 is closed
This issue is also closed
#45407 is not referencing 'Reload window' with restored terminal layout, just opening up options for this in the API for layout-management.

So solely restoring layout will never be VSCode native? Everyone keeps talking about 'sessions', I'm not

@Tyriar
Copy link
Member

Tyriar commented Oct 9, 2019

@vandijkstef see #44302 (comment) for the outcome of the layout experiment where it was just restoring the layout (splits and tabs). The issue is that it needs to be configurable as it might not be alright to launch 6 bash processes immediately on launching the window. The configuration ends up adding a lot of complexity/code to core which would be better to live in an extension.

Sorry this isn't the outcome you're after but we need to actively fight against bloat or VS Code will become slower and slower over time. An extension will eventually be able to do exactly what you want.

FYI there is also #20013 which we definitely do want to do which would keep everything including processes around between reloads (but probably not restarts).

@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*duplicate Issue identified as a duplicate of another issue(s)
Projects
None yet
Development

No branches or pull requests

2 participants