Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[A11y] Screenreader reads unrelated text before toast notification/alert contents #81787

Closed
Benjin opened this issue Oct 1, 2019 · 3 comments
Assignees
Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues *caused-by-extension Issue identified to be caused by an extension under-discussion Issue is under discussion for relevance, priority, approach workbench-notifications Notification widget issues
Milestone

Comments

@Benjin
Copy link

Benjin commented Oct 1, 2019

Environment Details:
Application Name: Visual Studio Code
Application Version: 1.38.1 (user setup)
Commit: b37e54
Electron: 4.2.10
Node.js: 10.11.0
OS: Windows_NT x64 10.0.18362

Repro steps:

  1. Go to Extensions
  2. Pick any ol' extension (confirmed on Java Extension Pack)
  3. Launch screen reader, like NVDA
  4. Use keyboard to select "Install" button
  5. Hit on keyboard

Expectation:
Toast content are read by the screen reader, as they're the most pertinent to the user's next action.

Reality:
Lots of intermediate text is read first, finally getting to the toast that's been waiting. Should have higher aria priority.

@Benjin
Copy link
Author

Benjin commented Oct 1, 2019

Refiling of #81484 with repro specific to VS Code

@Tyriar Tyriar assigned sandy081, isidorn and bpasero and unassigned sandy081 Oct 1, 2019
@bpasero bpasero removed their assignment Oct 2, 2019
@bpasero bpasero added accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues workbench-notifications Notification widget issues labels Oct 2, 2019
@isidorn
Copy link
Contributor

isidorn commented Oct 2, 2019

Assignign to next milestone to investigate then.

@isidorn
Copy link
Contributor

isidorn commented Oct 25, 2019

Same reasoning as #81786

I just tried this out and I disagree.
Notificatinos are something that is in the background and they should definentely not steal users attention by being read immediatly.

If every notification was doing this, then the user can be distributed all the time by random spam notifications from extensions. And this would lead to a very bad exeperience.

I am closing this as caused by extension and my recommendation is that the Java Extension Pack should use a modal dialog, and not a notificatino if the extension wants to focus to be switched to that and the user to be interupted.
I hope this makes sense, but all the API is there and it is up to the extension to decide which dialog should steal focus (use modal) and which not (use notifications).

Bottom line: notifications should not be obtrusive.

@isidorn isidorn closed this as completed Oct 25, 2019
@isidorn isidorn added the *caused-by-extension Issue identified to be caused by an extension label Oct 25, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Dec 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues *caused-by-extension Issue identified to be caused by an extension under-discussion Issue is under discussion for relevance, priority, approach workbench-notifications Notification widget issues
Projects
None yet
Development

No branches or pull requests

4 participants