Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typescript - Generate accessors autofix removes readonly modifier #81135

Closed
slaneyrw opened this issue Sep 19, 2019 · 1 comment
Closed

Typescript - Generate accessors autofix removes readonly modifier #81135

slaneyrw opened this issue Sep 19, 2019 · 1 comment
Assignees
Labels
javascript JavaScript support issues typescript Typescript support issues upstream Issue identified as 'upstream' component related (exists outside of VS Code)

Comments

@slaneyrw
Copy link

  • VSCode Version: 1.38.0 (system setup)
  • OS Version: Windows_NT x64 10.0.15063

Steps to Reproduce:

  1. Create private field with readonly modifier
  2. Highlight line and generate accessors
  3. get property created without set property ( correct ), but readonly modifier removed from field

Does this issue occur when all extensions are disabled?: Yes

@mjbvz mjbvz self-assigned this Sep 19, 2019
@mjbvz
Copy link
Collaborator

mjbvz commented Sep 19, 2019

This feature is powered by the TypeScript project. Please file a bug report upstream

@mjbvz mjbvz closed this as completed Sep 19, 2019
@mjbvz mjbvz added javascript JavaScript support issues upstream Issue identified as 'upstream' component related (exists outside of VS Code) typescript Typescript support issues labels Sep 19, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
javascript JavaScript support issues typescript Typescript support issues upstream Issue identified as 'upstream' component related (exists outside of VS Code)
Projects
None yet
Development

No branches or pull requests

2 participants