Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icon for new built-in "Image Preview" Extension #80677

Closed
mjbvz opened this issue Sep 11, 2019 · 5 comments
Closed

Icon for new built-in "Image Preview" Extension #80677

mjbvz opened this issue Sep 11, 2019 · 5 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded

Comments

@mjbvz
Copy link
Collaborator

mjbvz commented Sep 11, 2019

As part of our custom editor work (#77131), I've moved our image preview into a built-in extension. This extension needs a simple icon

@mjbvz mjbvz added this to the September 2019 milestone Sep 11, 2019
@miguelsolorio
Copy link
Contributor

miguelsolorio commented Sep 16, 2019

Would our generic "preview" icon work here?
image

Or do you think one with a picture inside would be better suited?
image

I'd be more inclined to use the generic one otherwise we could end up creating various versions for different types/

@mjbvz
Copy link
Collaborator Author

mjbvz commented Sep 16, 2019

Either works for me. It's going to be pretty hidden in the UI so it doesn't need to be anything fancy

@miguelsolorio
Copy link
Contributor

@mjbvz mjbvz closed this as completed in d54dbd3 Sep 16, 2019
@mjbvz mjbvz added the bug Issue identified by VS Code Team member as probable bug label Sep 30, 2019
@bpasero
Copy link
Member

bpasero commented Oct 1, 2019

Fyi there is a few more built in extensions without icon:

image

image

@bpasero bpasero added the verified Verification succeeded label Oct 1, 2019
@miguelsolorio
Copy link
Contributor

@bpasero created #81760 to track that

@vscodebot vscodebot bot locked and limited conversation to collaborators Oct 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

3 participants