Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reset trusted domains list for link protection #80333

Closed
garyking opened this issue Sep 4, 2019 · 8 comments · Fixed by #80951
Closed

Reset trusted domains list for link protection #80333

garyking opened this issue Sep 4, 2019 · 8 comments · Fixed by #80951
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded workbench-link Link protection in workbench

Comments

@garyking
Copy link

garyking commented Sep 4, 2019

Issue Type: Feature Request

Please allow us to delete trusted domains for link protection.

Selecting a domain and hitting Backspace and Delete don't do anything.

Even better would be to have an option to reset the list of links.

VS Code version: Code 1.38.0 (3db7e09, 2019-09-03T21:47:00.464Z)
OS version: Darwin x64 18.7.0

@vscodebot
Copy link

vscodebot bot commented Sep 4, 2019

(Experimental duplicate detection)
Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

@vscodebot vscodebot bot added the new release label Sep 4, 2019
@octref octref added info-needed Issue requires more information from poster and removed new release labels Sep 4, 2019
@octref
Copy link
Contributor

octref commented Sep 4, 2019

If you run Configure Trusted Domains, you can toggle off domains to delete them. Does that not work for you?

@garyking
Copy link
Author

garyking commented Sep 5, 2019

Okay thanks, that does indeed work. I thought it would just be a simple toggle.

Where it this data located? It would be nice to have it as an array in the VSC settings.json, like most of the other permanent settings.

@garyking garyking closed this as completed Sep 5, 2019
@octref
Copy link
Contributor

octref commented Sep 5, 2019

@garyking For security purposes, we decided to not put it in settings.json, which is writable by any extensions.

@garyking
Copy link
Author

garyking commented Sep 5, 2019

Is there any way to reset the list, other than doing it manually?

@octref
Copy link
Contributor

octref commented Sep 5, 2019

Double click the upper left checkbox should unselect all — or do you want reset instead of clear?

@garyking
Copy link
Author

garyking commented Sep 5, 2019

I would like an option to reset the list, so that if I added a bunch of custom URLs, then resetting the list would remove my custom URLs, and re-add any of the default URLs that I removed, if any.

@octref octref changed the title Delete a trusted domain for link protection Reset trusted domains list for link protection Sep 11, 2019
@octref octref added bug Issue identified by VS Code Team member as probable bug and removed info-needed Issue requires more information from poster labels Sep 11, 2019
@octref octref added this to the September 2019 milestone Sep 11, 2019
@octref octref reopened this Sep 11, 2019
@octref
Copy link
Contributor

octref commented Sep 15, 2019

See #80595 (comment)

@aeschli aeschli added the verified Verification succeeded label Oct 2, 2019
@octref octref added the workbench-link Link protection in workbench label Oct 29, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded workbench-link Link protection in workbench
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants