Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecated symbols: No indication in breadcrumb #79947

Closed
octref opened this issue Aug 27, 2019 · 2 comments
Closed

Deprecated symbols: No indication in breadcrumb #79947

octref opened this issue Aug 27, 2019 · 2 comments
Assignees
Labels
breadcrumbs under-discussion Issue is under discussion for relevance, priority, approach

Comments

@octref
Copy link
Contributor

octref commented Aug 27, 2019

Testing #79814:

More like a feature request. Would be great if breadcrumb show deprecated status as well:

image

Here's the code I'm using for generating the symbols:

	const symbols: vscode.SymbolInformation[] = [];
	for (let i = 0; i < 20; i++) {
		symbols.push({
			name: `foo${i}`,
			containerName: i === 0 ? '' : `${i - 1}`,
			kind: vscode.SymbolKind.Enum,
			location: new vscode.Location(
				vscode.window.activeTextEditor!.document.uri,
				new vscode.Range(0, 0, i * 2, 10)
			),
			tags: i % 2 === 0 || i % 3 === 0 ? [vscode.SymbolTag.Deprecated] : []
		});
	}

	vscode.languages.registerDocumentSymbolProvider('markdown', {
		provideDocumentSymbols() {
			return symbols;
		}
	});
@jrieken jrieken added breadcrumbs under-discussion Issue is under discussion for relevance, priority, approach labels Aug 28, 2019
@jrieken
Copy link
Member

jrieken commented Aug 28, 2019

That was done on purpose (see #50972 (comment)) to prevent visual noise and because the breadcrumb shows the active function/symbol (e.g where your cursor is) and from there you should be able to see if something is deprecated or not

@octref
Copy link
Contributor Author

octref commented Aug 28, 2019

Makes sense, I'd be fine without it in breadcrumbs.

@octref octref closed this as completed Aug 28, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Oct 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
breadcrumbs under-discussion Issue is under discussion for relevance, priority, approach
Projects
None yet
Development

No branches or pull requests

2 participants