Link protection prompts for github.com although it is in trusted domain

[stevencl]

Issue Type: Bug
Testing: #79465
Open release notes
Click August Iteration Plan link (#78844)
Get prompted if i want to open this external website
Click 'Configure Trusted Domains'
See that https://github.com is already checked
Expected: When clicking the August Iteration Plan link, the link should just open since it is marked as trusted

VS Code version: Code - Insiders 1.38.0-insider (8cd00a7, 2019-08-27T06:13:54.903Z)
OS version: Windows_NT x64 10.0.18362

System Info

Item	Value
CPUs	Intel(R) Core(TM) i7-8650U CPU @ 1.90GHz (8 x 2112)
GPU Status	2d_canvas: enabled flash_3d: enabled flash_stage3d: enabled flash_stage3d_baseline: enabled gpu_compositing: enabled multiple_raster_threads: enabled_on native_gpu_memory_buffers: disabled_software oop_rasterization: disabled_off protected_video_decode: enabled rasterization: enabled skia_deferred_display_list: disabled_off skia_renderer: disabled_off surface_synchronization: enabled_on video_decode: enabled viz_display_compositor: disabled_off webgl: enabled webgl2: enabled
Load (avg)	undefined
Memory (System)	15.93GB (2.34GB free)
Process Argv
Screen Reader	yes
VM	0%

Extensions (12)

Extension	Author (truncated)	Version
tslint	eg2	1.0.44
vscode-github-releases-updater	joa	0.17.0
vscode-docker	ms-	0.7.0
python	ms-	2019.8.30787
remote-containers	ms-	0.69.0
remote-ssh	ms-	0.45.6
remote-ssh-edit	ms-	0.45.6
remote-ssh-explorer	ms-	0.45.6
remote-wsl	ms-	0.39.4
vscode-remote-extensionpack	ms-	0.16.0
azure-account	ms-	0.8.4
test-search-rg	rob	0.0.3

[stevencl]

The issue is that it wasn't obvious when the configure trusted domains widget came up that the user has to press OK. On first launch there should be a prompt to tell the user to click ok to accept the defaults. Or by default nothing should be checked which would make it more obvious that the user can check the ones that they want to trust and then click OK.

[octref]

We do have some details text that explains what the item does:

Or by default nothing should be checked

I think if user is not interested in trusting the domain, he would have clicked the default action "Open Link", so I feel this should be opt-out.

[vscodebot]

Thanks for creating this issue! We figured it's covering the same as another one we already have. Thus, we closed this one as a duplicate. You can search for existing issues here. See also our issue reporting guidelines.

Happy Coding!

[octref]

Merged to #80489.