Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MarkupContent: Link not rendered when space exists on line start #78717

Closed
octref opened this issue Aug 8, 2019 · 3 comments
Closed

MarkupContent: Link not rendered when space exists on line start #78717

octref opened this issue Aug 8, 2019 · 3 comments
Assignees
Labels
*as-designed Described behavior is as designed markdown Markdown support issues

Comments

@octref
Copy link
Contributor

octref commented Aug 8, 2019

Use below MarkupContent to return hover and completion in LSP sample:

const markupContent: MarkupContent =  {
	kind: 'markdown',
	value: `
   	[I'm an inline-style link](https://www.google.com)`
};

image

image

@jrieken jrieken added bug Issue identified by VS Code Team member as probable bug upstream Issue identified as 'upstream' component related (exists outside of VS Code) markdown Markdown support issues labels Aug 8, 2019
@jrieken
Copy link
Member

jrieken commented Aug 8, 2019

We use 'marked' for this... Not sure if this is by design or a bug

@octref octref self-assigned this Aug 15, 2019
@octref octref added this to the August 2019 milestone Aug 19, 2019
@octref octref modified the milestones: August 2019, September 2019 Aug 27, 2019
@octref octref added *as-designed Described behavior is as designed and removed bug Issue identified by VS Code Team member as probable bug labels Sep 17, 2019
@vscodebot
Copy link

vscodebot bot commented Sep 17, 2019

The described behavior is how it is expected to work. If you disagree, please explain what is expected and what is not in more detail. See also our issue reporting guidelines.

Happy Coding!

@octref octref removed the upstream Issue identified as 'upstream' component related (exists outside of VS Code) label Sep 17, 2019
@vscodebot vscodebot bot closed this as completed Sep 17, 2019
@octref
Copy link
Contributor Author

octref commented Sep 17, 2019

After reading CommonMarks spec I realized 4 spaces => code block, so it's correct to render it as code blocks in hover.

And as for completion...It's a matter of wrapping. I just needed to scroll down...

image

@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*as-designed Described behavior is as designed markdown Markdown support issues
Projects
None yet
Development

No branches or pull requests

2 participants