Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete vscode-nsfw #74897

Closed
joaomoreno opened this issue Jun 5, 2019 · 3 comments
Closed

Delete vscode-nsfw #74897

joaomoreno opened this issue Jun 5, 2019 · 3 comments
Assignees
@bpasero @Tyriar
Labels
file-watcher File watcher under-discussion Issue is under discussion for relevance, priority, approach

Comments

@joaomoreno
Copy link
Member

I tried investigating what is the difference between nsfw and vscode-nsfw. I might be wrong, but there seems to be no different right now, so it looks like vscode-nsfw is just debt. Commits from @Tyriar and @alexandrudima are in the upstream project.

I suggest to just depend on nsfw and delete vscode-nsfw from npm and github.
@joaomoreno joaomoreno added the debt Code quality issues label Jun 5, 2019
@Tyriar Tyriar added this to the June 2019 milestone Jun 5, 2019
@Tyriar Tyriar added the file-watcher File watcher label Jun 5, 2019
@Tyriar
Copy link
Member

Tyriar commented Jun 5, 2019

Here's the diff, we're 2 commits ahead and 18 behind (removing win_delay_load_hook and updating nan):

Axosoft/nsfw@master...microsoft:vscode

The win_delay_load_hook thing is on the upstream (Axosoft/nsfw@c3fa075) but the update to nan isn't so I don't think we can update and keep Electron 5 support?

@Tyriar Tyriar removed this from the June 2019 milestone Jun 5, 2019
@bpasero
Copy link
Member

bpasero commented Jun 5, 2019 •
edited
Loading

We should not invest here, but rather make chokidar 3.x work across all platforms. I posted my initial testing results in paulmillr/chokidar#860.

I suggest to close this item given we still have changes in vscode-nsfw that are not upstream.

@bpasero bpasero added under-discussion Issue is under discussion for relevance, priority, approach and removed debt Code quality issues labels Jun 5, 2019
@Tyriar Tyriar closed this as completed Jun 5, 2019
@joaomoreno
Copy link
Member Author

My bad!

@vscodebot vscodebot bot locked and limited conversation to collaborators Jul 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bpasero bpasero

@Tyriar Tyriar

Labels
file-watcher File watcher under-discussion Issue is under discussion for relevance, priority, approach
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@joaomoreno @bpasero @Tyriar @alexdima