Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[powershell] add here-string autoClosingPairs to PowerShell #73047

Closed
msftrncs opened this issue Apr 29, 2019 · 5 comments
Closed

[powershell] add here-string autoClosingPairs to PowerShell #73047

msftrncs opened this issue Apr 29, 2019 · 5 comments
Assignees
Labels
editor-autoclosing Editor automatic closing of parens / brackets / etc. feature-request Request for new features or functionality languages-basic Basic language support issues

Comments

@msftrncs
Copy link

Consider adding autoClosingPairs to PowerShell language configuration for @'..'@ and @"..."@.

However, to do so would require fixing some issues, such as #72177 because these patterns conflict with regular quoted string patterns. Ideally the closing pair should inject a \n (newline, before the closing token), but that causes the cursor to jump to after the newline (in the cases were I have tested it with non-conflicting pairs). Alternatively, if a newline was allowed in the opening pair detection, that could be an option too.

These pairs would probably also require "notIn": ["string", "comment"].

@vscodebot vscodebot bot added the editor-autoclosing Editor automatic closing of parens / brackets / etc. label Apr 29, 2019
@RMacfarlane RMacfarlane added the languages-basic Basic language support issues label Apr 30, 2019
@aeschli aeschli added this to the Backlog milestone May 2, 2019
@aeschli aeschli changed the title add here-string autoClosingPairs to PowerShell [poershell] add here-string autoClosingPairs to PowerShell May 2, 2019
@alexdima alexdima added the feature-request Request for new features or functionality label Aug 8, 2019
@aeschli aeschli changed the title [poershell] add here-string autoClosingPairs to PowerShell [powershell] add here-string autoClosingPairs to PowerShell Oct 9, 2019
@alexdima alexdima modified the milestones: Backlog, Backlog Candidates Oct 24, 2019
@vscodebot
Copy link

vscodebot bot commented Jan 15, 2020

This feature request is now a candidate for our backlog. The community has 60 days to upvote the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our documentation.

Happy Coding!

@rmunn
Copy link
Contributor

rmunn commented Jan 17, 2020

The linked issue (#72177) is also in danger of being closed if it doesn't get upvotes. Anyone interested in getting this annoyance fixed should probably upvote #72177 so it can get moved to the VS Code backlog and the VS Code devs have a chance of seeing it.

@vscodebot
Copy link

vscodebot bot commented Mar 6, 2020

This feature request has not yet received the 20 community upvotes it takes to make to our backlog. 10 days to go. To learn more about how we handle feature requests, please see our documentation.

Happy Coding

1 similar comment
@vscodebot
Copy link

vscodebot bot commented Mar 6, 2020

This feature request has not yet received the 20 community upvotes it takes to make to our backlog. 10 days to go. To learn more about how we handle feature requests, please see our documentation.

Happy Coding

@vscodebot
Copy link

vscodebot bot commented Mar 16, 2020

🙁 In the last 60 days, this feature request has received less than 20 community upvotes and we closed it. Still a big Thank You to you for taking the time to create this issue! To learn more about how we handle feature requests, please see our documentation.

Happy Coding!

@vscodebot vscodebot bot closed this as completed Mar 16, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Apr 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
editor-autoclosing Editor automatic closing of parens / brackets / etc. feature-request Request for new features or functionality languages-basic Basic language support issues
Projects
None yet
Development

No branches or pull requests

5 participants