Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typescript Intellisense slow when using yarn workspaces #72690

Closed
charlie632 opened this issue Apr 21, 2019 · 18 comments
Closed

Typescript Intellisense slow when using yarn workspaces #72690

charlie632 opened this issue Apr 21, 2019 · 18 comments
Assignees
Labels
info-needed Issue requires more information from poster

Comments

@charlie632
Copy link

  • VSCode Version: 1.33.1 (User)
  • OS Version: Window 10

Steps to Reproduce:

  1. Created a simple Yarn workspaces project with nextjs
  2. Intellisese was way too slow
  3. Disabled all extensions. No improvement.
  4. Reinstalled VSCode. Still, no improvement.
  5. Switched to another project (Large project without Yarn Workspaces): Intellisense worked perfectly.

I used to work on a project with Lerna and was not having this kind of issue. Maybe is a yarn related issue?

Does this issue occur when all extensions are disabled?: Yes

@fabb
Copy link

fabb commented Apr 24, 2019

Our whole team experiences very slow indexing, autocompletion and code hinting for our TypeScript next.js project since updating to VSCode 1.33.1 as well. It worked multiple times faster in the previous version of VSCode. Something is wrong.

@codepunkt
Copy link

I can confirm this. It is borderline unusable in the current version, i reverted back to 1.32.x

@fabb
Copy link

fabb commented Apr 26, 2019

Btw we don‘t use yarn but npm.

@fabb
Copy link

fabb commented Apr 26, 2019

Maybe related to #72472?

@fabb
Copy link

fabb commented Apr 26, 2019

Here is my collected performance data:

VS Code version: Code 1.33.1 (51b0b28, 2019-04-11T08:22:55.268Z)
OS version: Darwin x64 18.5.0

System Info
Item Value
CPUs Intel(R) Core(TM) i5-4308U CPU @ 2.80GHz (4 x 2800)
GPU Status 2d_canvas: enabled
checker_imaging: disabled_off
flash_3d: enabled
flash_stage3d: enabled
flash_stage3d_baseline: enabled
gpu_compositing: enabled
multiple_raster_threads: enabled_on
native_gpu_memory_buffers: enabled
rasterization: enabled
surface_synchronization: enabled_on
video_decode: enabled
webgl: enabled
webgl2: enabled
Load (avg) 3, 4, 4
Memory (System) 16.00GB (0.32GB free)
Process Argv
Screen Reader no
VM 0%
Process Info
CPU %	Mem MB	   PID	Process
   19	    82	 99785	code main
    6	   213	 99787	   gpu-process
    0	   410	 99788	   window (theme.tsx — Yet Another Project Name)
    0	     0	   225	     /bin/bash -l
    0	    16	 39063	       npm
    0	     0	 39065	         sh -c ./local-proxy/run_proxy.sh && cross-env PORT=3002 npm run dev:no-proxy
    0	    16	 39093	           node /path/to/my/project/node_modules/.bin/cross-env PORT=3002 npm run dev:no-proxy
    0	    16	 39094	             npm
    0	    16	 39095	               node /path/to/my/project/node_modules/.bin/cross-env NODE_ENV=development nodemon ./server.ts
    0	    16	 39096	                 node /path/to/my/project/node_modules/.bin/nodemon ./server.ts
    0	   606	 39098	                   node /path/to/my/project/node_modules/.bin/ts-node -r tsconfig-paths/register --project tsconfig.server.json --files ./server.ts
    5	   311	 39419	                     /Users/me/.nvm/versions/node/v10.15.3/bin/node --max-old-space-size=2048 /path/to/my/project/node_modules/fork-ts-checker-webpack-plugin/lib/service.js
    0	   164	 99789	   window (package.json — wh-components)
    0	     0	   689	     /bin/bash -l
Workspace Info
|  Window (somefile.js — Project Name)
|  Window (package.json — Other Project Name)
|  Window (theme.tsx — Yet Another Project Name)
|    Folder (Tealium_BBX_OEWA): 13 files
|      File types: js(6) json(5) gitignore(1) md(1)
|      Conf files: package.json(1) settings.json(1)
|    Folder (wh-components): 539 files
|      File types: html(128) js(122) svg(74) ts(62) tsx(51) less(47) json(13)
|                  xml(11) DS_Store(10) npmrc(2)
|      Conf files: package.json(2) gulp.js(1) jsconfig.json(1)
|                  tsconfig.json(1) tslint.json(1) webpack.config.js(1)
|                  launch.json(1) settings.json(1) tasks.json(1)
|    Folder (Yet Another Project Name): 497 files
|      File types: tsx(155) ts(86) less(58) js(39) svg(31) json(31) map(29)
|                  html(19) xml(11) jpg(6)
|      Conf files: package.json(1) tsconfig.json(1) tslint.json(1)
|                  launch.json(1) settings.json(1);
Extensions (30)
Extension Author (truncated) Version
rainbow-brackets 2gu 0.0.6
Bookmarks ale 10.4.3
scratchpads bue 0.0.5
path-intellisense chr 1.4.2
vscode-eslint dba 1.8.2
githistory don 0.4.6
gitlens eam 9.6.3
EditorConfig Edi 0.13.0
vscode-npm-script eg2 0.3.5
prettier-vscode esb 1.9.0
duplicate gee 1.0.1
todo-tree Gru 0.0.130
bats jet 0.1.3
vscode-styled-components jpo 0.0.26
intellij-idea-keybindings k-- 0.2.31
brittany Max 0.0.6
vscode-less mrm 0.6.3
vscode-typescript-tslint-plugin ms- 1.0.0
debugger-for-chrome msj 4.11.3
color-highlight nau 2.3.0
vscode-docker Pet 0.6.1
java red 0.43.0
vscode-sort-json ric 1.13.0
partial-diff ryu 1.4.0
stylelint shi 0.49.0
vscode-java-debug vsc 0.18.0
vscode-icons vsc 8.6.0
quokka-vscode Wal 1.0.209
vscode-todo-highlight way 1.0.4
vscode-import-cost wix 2.12.0

@mjbvz
Copy link
Collaborator

mjbvz commented Apr 26, 2019

@fabb Please open a separate issue to track your problem

@charlie632 Do you have @types/styled components installed under node_modules? See DefinitelyTyped/DefinitelyTyped#34391

@mjbvz mjbvz added the info-needed Issue requires more information from poster label Apr 26, 2019
@charlie632
Copy link
Author

@mjbvz I have @types/styled-components.

But I changed my monorepo out from yarn workspaces to a Lerna monorepo and the performance was significantly better. Below is my current pacakage.json.

 "dependencies": {
    "@material-ui/core": "4.0.0-alpha.8",
    "@material-ui/styles": "4.0.0-alpha.8",
    "@zeit/next-typescript": "^1.1.1",
    "@zeit/webpack-asset-relocator-loader": "^0.4.1",
    "firebase": "5.7.1",
    "next": "^8.1.0",
    "next-compose-plugins": "^2.1.1",
    "react": "^16.8.6",
    "react-dom": "^16.8.6",
    "react-spring": "^8.0.19",
    "remcalc": "^1.0.10",
    "styled-components": "^4.2.0",
    "styled-theming": "^2.2.0"
  },
  "devDependencies": {
    "@types/next": "^8.0.3",
    "@types/react": "^16.8.14",
    "@types/react-dom": "^16.8.4",
    "@types/styled-components": "^4.1.14",
    "@types/styled-jsx": "^2.2.8",
    "babel-plugin-styled-components": "^1.10.0",
    "typescript": "^3.4.4"
  }

@mjbvz
Copy link
Collaborator

mjbvz commented Apr 26, 2019

When you changed repo structure, is it possible that you also installed a newer version of @types/styled-components. See DefinitelyTyped/DefinitelyTyped#34391 for a possible root cause of this

@charlie632
Copy link
Author

Let me see my old commits

@fabb
Copy link

fabb commented Apr 26, 2019

Thanks for the hint on styled-components, that might affect me too. I‘ll investigate some more before I create a new issue.
Unfortunately I‘m stuck with @types/[email protected] because of DefinitelyTyped/DefinitelyTyped#33015

@roniemeque
Copy link

Our whole team experiences very slow indexing, autocompletion and code hinting for our TypeScript next.js project since updating to VSCode 1.33.1 as well. It worked multiple times faster in the previous version of VSCode. Something is wrong.

Started having the same issue and fresh install/plugin cleaning didn't work, had to rollback to 1.30.

@Bobvantpadje
Copy link

We're having the same issue. For us it's related to @types/styled-components. If we remove this package or rollback to VSCode 1.30 the intellisense is fast again.

@mjbvz
Copy link
Collaborator

mjbvz commented May 3, 2019

@Bobvantpadje Did you try updating to the latest @types/styled-components? see DefinitelyTyped/DefinitelyTyped#34391

@fabb
Copy link

fabb commented May 4, 2019

For our project, updating to the latest @types/styled-components did not help, just rolling back to 3.3 helped a bit.

@focux
Copy link

focux commented May 19, 2019

For me, updating @types/styled-components to 4.1.15 worked, thank you.

@mjbvz
Copy link
Collaborator

mjbvz commented May 21, 2019

@charlie632 Can you please test this again in the latest VS Code insiders build too?

@imoby
Copy link

imoby commented May 22, 2019

Upgrading to the latest version of styled-components didnt work for me

@mjbvz
Copy link
Collaborator

mjbvz commented May 29, 2019

Closing as we need more info from the original poster.

Based on the description, this is like a duplicate of microsoft/TypeScript#30819

@mjbvz mjbvz closed this as completed May 29, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Jul 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
info-needed Issue requires more information from poster
Projects
None yet
Development

No branches or pull requests

8 participants