-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Typescript Intellisense slow when using yarn workspaces #72690
Comments
Our whole team experiences very slow indexing, autocompletion and code hinting for our TypeScript next.js project since updating to VSCode 1.33.1 as well. It worked multiple times faster in the previous version of VSCode. Something is wrong. |
I can confirm this. It is borderline unusable in the current version, i reverted back to 1.32.x |
Btw we don‘t use yarn but npm. |
Maybe related to #72472? |
Here is my collected performance data: VS Code version: Code 1.33.1 (51b0b28, 2019-04-11T08:22:55.268Z) System Info
Process Info
Workspace Info
Extensions (30)
|
@fabb Please open a separate issue to track your problem @charlie632 Do you have |
@mjbvz I have But I changed my monorepo out from yarn workspaces to a Lerna monorepo and the performance was significantly better. Below is my current pacakage.json. "dependencies": {
"@material-ui/core": "4.0.0-alpha.8",
"@material-ui/styles": "4.0.0-alpha.8",
"@zeit/next-typescript": "^1.1.1",
"@zeit/webpack-asset-relocator-loader": "^0.4.1",
"firebase": "5.7.1",
"next": "^8.1.0",
"next-compose-plugins": "^2.1.1",
"react": "^16.8.6",
"react-dom": "^16.8.6",
"react-spring": "^8.0.19",
"remcalc": "^1.0.10",
"styled-components": "^4.2.0",
"styled-theming": "^2.2.0"
},
"devDependencies": {
"@types/next": "^8.0.3",
"@types/react": "^16.8.14",
"@types/react-dom": "^16.8.4",
"@types/styled-components": "^4.1.14",
"@types/styled-jsx": "^2.2.8",
"babel-plugin-styled-components": "^1.10.0",
"typescript": "^3.4.4"
} |
When you changed repo structure, is it possible that you also installed a newer version of |
Let me see my old commits |
Thanks for the hint on |
Started having the same issue and fresh install/plugin cleaning didn't work, had to rollback to 1.30. |
We're having the same issue. For us it's related to |
@Bobvantpadje Did you try updating to the latest @types/styled-components? see DefinitelyTyped/DefinitelyTyped#34391 |
For our project, updating to the latest |
For me, updating |
@charlie632 Can you please test this again in the latest VS Code insiders build too? |
Upgrading to the latest version of styled-components didnt work for me |
Closing as we need more info from the original poster. Based on the description, this is like a duplicate of microsoft/TypeScript#30819 |
Steps to Reproduce:
I used to work on a project with Lerna and was not having this kind of issue. Maybe is a yarn related issue?
Does this issue occur when all extensions are disabled?: Yes
The text was updated successfully, but these errors were encountered: