Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

createWebviewPanel doesn't fire WebviewPanelOnDidChangeViewStateEvent to other webviews #70859

Closed
jdoklovic opened this issue Mar 20, 2019 · 2 comments
Assignees
Labels
api bug Issue identified by VS Code Team member as probable bug verified Verification succeeded webview Webview issues
Milestone

Comments

@jdoklovic
Copy link

jdoklovic commented Mar 20, 2019

  • VSCode Version: 1.32.3
  • OS Version: ubuntu 18.04

Steps to Reproduce:

  1. create a webview
  2. add an onDidChangeViewState handler
  3. output a log message with it's visibility when it receives the event
  4. create a different webview that also logs visibility in it's onDidChangeViewState handler

Expected log output:
create first webview ->

  • "webview one visible: true"

create second webview ->

  • "webview two visible: true"
  • "webview one visible: false"

Actual log output:
create first webview ->

  • "webview one visible: true"

create second webview ->

  • "webview two visible: true"

Note: After both are open, if you click between their tabs a couple of times, the events start working properly.

@mjbvz mjbvz self-assigned this Mar 20, 2019
@jdoklovic
Copy link
Author

jdoklovic commented Mar 20, 2019

@mjbvz
I've created a repo that re-creates this issue here:
https://github.com/atlassian/webvieweventtest

just follow the readme.

@mjbvz mjbvz added bug Issue identified by VS Code Team member as probable bug api webview Webview issues labels Mar 21, 2019
@mjbvz mjbvz added this to the April 2019 milestone Mar 21, 2019
@mjbvz mjbvz closed this as completed in 06dd68b Apr 3, 2019
@alexr00 alexr00 added the verified Verification succeeded label May 8, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators May 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api bug Issue identified by VS Code Team member as probable bug verified Verification succeeded webview Webview issues
Projects
None yet
Development

No branches or pull requests

3 participants