-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Problem view padding is inconsistent #69382
Comments
Fixed the scroll bar and focus issues. But it is hard to have consistent padding because it involves computing height using number of lines. Actually this looks same also before and the difference in padding is not so much to consider. |
@Tyriar This is how it looks with and without a link. I don't see any sloppiness |
@sandy081 the bottom padding of the container should match the top padding of the container, just like in the second screenshot? |
I'm guessing this should be reopened? I also spun another issue off this: #69495 |
Since this is not a regression, moving this to March |
Sorry @Tyriar. Looked into it again to make the padding symmetric. But I am sorry to say this need bigger changes to peek widget which I am not willing to do for the value it gives. Moreover it is like this from beginning. Hence closing this as wont fix. |
#69204
The top and bottom padding is inconsistent.
Looks like it's related to "invisible" items inside the body:
Version: 1.32.0-insider (user setup)
Commit: 393b48d
Date: 2019-02-25T01:34:48.785Z
Electron: 3.1.3
Chrome: 66.0.3359.181
Node.js: 10.2.0
V8: 6.6.346.32
OS: Windows_NT x64 10.0.18841
The text was updated successfully, but these errors were encountered: