Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

InstantiationService with proxys: allow to be used in browser namespace #69141

Closed
bpasero opened this issue Feb 21, 2019 · 3 comments
Closed

InstantiationService with proxys: allow to be used in browser namespace #69141

bpasero opened this issue Feb 21, 2019 · 3 comments
Assignees
@jrieken
Labels
debt Code quality issues
Milestone
March 2019

Comments

@bpasero
Copy link
Member

bpasero commented Feb 21, 2019 •
edited
Loading

Refs #68302

I will need to be able to use the src/vs/platform/instantiation/node/instantiationService.ts when node is disabled, can we move it to browser land? Possibly in workbench maybe if the challenge is about standalone editor usage?
@bpasero bpasero added the debt Code quality issues label Feb 21, 2019
@bpasero bpasero mentioned this issue Feb 21, 2019
Closed
17 tasks
@jrieken
Copy link
Member

jrieken commented Feb 24, 2019

Yeah, not easy without tricks. Our browser-layer is IE11 and that doesn't support ES proxies...

@jrieken jrieken added this to the March 2019 milestone Feb 24, 2019
@bpasero
Copy link
Member Author

bpasero commented Feb 25, 2019

Maybe we should revive that "IE11-support" discussion...

@jrieken jrieken closed this as completed in 489dfec Mar 4, 2019
@jrieken
Copy link
Member

jrieken commented Mar 4, 2019

Trying to avoid the IE11-discussion. I pushed a fix that ghetto-hacks around this by locally declaring Proxy and by running feature detection inside the service.

@vscodebot vscodebot bot locked and limited conversation to collaborators Apr 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jrieken jrieken

Labels
debt Code quality issues
Projects
None yet
Milestone
March 2019
Development

No branches or pull requests
2 participants
@bpasero @jrieken