Cmd / Ctrl + clicking a URL with %2Fs causes the %2Fs to be replaced with slashes

[tallpants]

Not sure why this is happening, but could be related to #4315.

Example:

On cmd + clicking this is the URL that gets opened:

Confirmed that this happens with every browser (at least on macOS). Currently running version 1.31.11

[tallpants]

I was able to narrow it down to here -- https://github.com/Microsoft/vscode/blob/master/src/vs/base/common/uri.ts#L267

For reference, I came across this issue while trying to cmd + click an AWS S3 presigned URL (that have %2F in the path).

The example URL in the image above is invalid in Chromium -- but here's a valid URL that window.open opens just fine in Chromium: https://something.com/hello%2Fworld

But in vscode, what gets passed to window.open (here: https://github.com/Microsoft/vscode/blob/master/src/vs/base/browser/dom.ts#L1151) is already modified and no longer matches the original URL.

[kieferrm]

/duplicate of #25852

[vscodebot]

Thanks for creating this issue! We figured it's covering the same as another one we already have. Thus, we closed this one as a duplicate. You can search for existing issues here. See also our issue reporting guidelines.

Happy Coding!