Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

contentprovider-sampler: remove 'out' folder from repository #6813

Closed
weinand opened this issue May 24, 2016 · 7 comments
Closed

contentprovider-sampler: remove 'out' folder from repository #6813

weinand opened this issue May 24, 2016 · 7 comments
Assignees
@weinand
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Milestone
May 2016

Comments

@weinand
Copy link
Contributor

weinand commented May 24, 2016 •
edited
Loading

testing #6675:

  • Remove 'out' folder from contentprovider-sampler sample. The other samples do not have the generated code and maps either.
  • The contentprovider-sampler does not have a '.vscode' folder with launch configuration. This is inconsistent with the other sample folders.
@jrieken jrieken added this to the May 2016 milestone May 24, 2016
@jrieken jrieken added the bug Issue identified by VS Code Team member as probable bug label May 24, 2016
@jrieken
Copy link
Member

jrieken commented May 25, 2016

fixed by microsoft/vscode-extension-samples@aa698ac

@jrieken jrieken closed this as completed May 25, 2016
@weinand
Copy link
Contributor Author

weinand commented May 25, 2016

@jrieken oops, I just noticed another inconsistency and added it here while you were closing this...

@jrieken
Copy link
Member

jrieken commented May 25, 2016

ok - reopen

@jrieken jrieken reopened this May 25, 2016
@weinand
Copy link
Contributor Author

weinand commented May 25, 2016

@jrieken where does the folder 'etc' come from?

@jrieken
Copy link
Member

jrieken commented May 25, 2016

I have no clue, maybe @aeschli knows?

@jrieken
Copy link
Member

jrieken commented May 25, 2016

added the .vscode folder with microsoft/vscode-extension-samples@e08c1d4

@jrieken jrieken closed this as completed May 25, 2016
@aeschli
Copy link
Contributor

aeschli commented May 25, 2016

I'm also puzzled by the occasional showing up of the etc folder.

@jrieken jrieken assigned weinand and unassigned jrieken May 26, 2016
@weinand weinand added the verified Verification succeeded label May 27, 2016
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@weinand weinand

Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
Milestone
May 2016
Development

No branches or pull requests
3 participants
@jrieken @weinand @aeschli