Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test GitHub Pull Request GraphQL changes #67297

Closed
2 tasks done
RMacfarlane opened this issue Jan 28, 2019 · 1 comment
Closed
2 tasks done

Test GitHub Pull Request GraphQL changes #67297

RMacfarlane opened this issue Jan 28, 2019 · 1 comment

Comments

@RMacfarlane
Copy link
Contributor

RMacfarlane commented Jan 28, 2019

Test for microsoft/vscode-pull-request-github#762

Authors: @rebornix, @RMacfarlane

We have migrated much of the communication with GitHub from the REST version of their API to the new GraphQL version. This item is to test that there have been no regressions in the extension's behavior. This includes

  • The PR tree view should list PRs and associated file changes
  • The description webview should present all commits and comments of the PR, and all links on it should be functional
  • Creating, editing, and deleting comments should work (There is a separate test item for the new reviews flow beginning with Start Review, this is adding individual comments as before)

Please use the nightly build of the extension to test, and file issues at https://github.com/Microsoft/vscode-pull-request-github. You can use this repo for testing

Complexity: 3

@auchenberg
Copy link
Contributor

I take MacOS!

@miguelsolorio miguelsolorio removed their assignment Jan 29, 2019
@auchenberg auchenberg removed their assignment Jan 30, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Mar 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants
@auchenberg @RMacfarlane @gregvanl @miguelsolorio and others