Custom title bar uses Windows styling on Linux distributions

[zachbr]

Version: 1.30.0
Commit: c6e592b
Date: 2018-12-11T22:21:33.585Z
Electron: 2.0.12
Chrome: 61.0.3163.100
Node.js: 8.9.3
V8: 6.1.534.41
OS: Linux (various, see below)

Steps to Reproduce:

1. Install vscode 1.30.0 on any Linux distro and run it
2. Compare vscode's titlebar with native applications.

Does this issue occur when all extensions are disabled?: Yes/No
Yes

While the new title bar is nice, enabling it by default on Linux and having it ignore the distribution and user's desktop themes makes vscode look very out of place. On some distributions it isn't too bad. However on others it can look quite out of place on the system. This is not all that different from a Windows application using a macOS style title bar, or vice-versa.

Ideally, vscode's custom title bar should make an attempt to respect the style set forth by the desktop environment. Failing that, perhaps it would be better to disable this feature by default in order to maintain cohesion with the desktop environment, allowing advanced users or those who don't care to enable it manually in settings.

Ubuntu 18.10 (Linux x64 4.18.0-10-generic)

Fedora 29 (Linux x64 4.18.16-300.fc29.x86_64)

KDE Neon (Linux x64 4.15.0-39-generic)

elementaryOS (Linux x64 4.15.0-42-generic)

Decided to test vscode insider for this last one.

Version: 1.31.0-insider
Commit: edf1090b8546ad0d17f30bf6f8075613e37e1b37
Date: 2018-12-17T10:01:26.915Z
Electron: 3.0.10
Chrome: 66.0.3359.181
Node.js: 10.2.0
V8: 6.6.346.32
OS: Linux x64 4.15.0-42-generic

[omentic]

+1

Adding onto this, only the [X] does anything on my setup. And as far as I know, there is no option in the "view" menu to hide it like the menu bar.

[clee]

I'd like to point out that in addition to custom titlebars not matching the window manager's styling on Linux, VSCode also doesn't match the button order, which is much more important to me personally. I've attached a screenshot showing a variety of apps showing how they support proper custom button order support here.

• gnome-terminal just uses the standard WM decorations, and gets the proper button order
• nautilus has a funky custom HeaderBar widget, but also gets the proper button order
• chrome, which is only barely more native than vscode, gets the proper button order (and icons!)
• vscode is the odd GUI out, getting the button order and icons wrong

[kienner-philippe]

To me the most important thing is that with this custom title bar (or no more title bar?), the right-click menu allowing me to move the window to another X11 workspace (virtual display) disappeared.
I find this really annoying. The VS Code window has to stick into the workspace it has been started.
Thanks for giving back this (stolen ;-) functionality.

Thanks also for the good job,
I love VS Code.
Philippe

[kienner-philippe]

This menu is not availble anymore (Move to Workspace X).

[sbatten]

/duplicate
#65608

[vscodebot]

Thanks for creating this issue! We figured it's covering the same as another one we already have. Thus, we closed this one as a duplicate. You can search for existing issues here. See also our issue reporting guidelines.

Happy Coding!