Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Annoying split view on "Open Keyboard Shortcuts File" #65063

Closed
timfayz opened this issue Dec 14, 2018 · 5 comments
Closed

Annoying split view on "Open Keyboard Shortcuts File" #65063

timfayz opened this issue Dec 14, 2018 · 5 comments
Assignees
Labels
keybindings-editor Keybinding editor issues

Comments

@timfayz
Copy link

timfayz commented Dec 14, 2018

I just want to revive the issue opened 1.5 year ago #28633. I think the author make his best to explain and show what is really annoying and what really might be improved as it was already done in "Preference: Open Settings (JSON)". To refresh the idea, it can be state as this:

  • Instead of opening two new tabs in split view - those clattering working space - let's just open one tab and provide special split view within that tab (as when you open settings.json through "Preference: Open Settings (JSON)")

Or let's make the following:

image

To look like this:

image

Hope that make a sense. Thank you! :)

@timfayz timfayz changed the title Annoying two new tabs on "Open Keyboard Shortcuts File" Annoying split view on "Open Keyboard Shortcuts File" Dec 14, 2018
@sandy081 sandy081 added the keybindings-editor Keybinding editor issues label Dec 16, 2018
@sandy081 sandy081 modified the milestone: December/January 2019 Dec 16, 2018
@sandy081
Copy link
Member

Closing this because, we are moving away from that split JSON also in settings editor in favour of the UI.

@roblourens Can you please link to the corresponding issue?

@roblourens
Copy link
Member

#64932

@timfayz
Copy link
Author

timfayz commented Dec 18, 2018

Thank you)

@thernstig
Copy link
Contributor

@timfayz I am not sure you will be so thankful when you understand they are actually removing the feature you like in the settings JSON view. So the one thing you like about it is being removed. Everyone who understand this have down-voted it, but we are not heard. Please read #64932

@timfayz
Copy link
Author

timfayz commented Dec 19, 2018

@thernstig, thank you for pointing the issue. It even helped me to solve (or at least to make a workaround) for this particular issue. The @roblourens says back there:

Also, we currently already have a setting workbench.settings.openDefaultSettings which allows exactly the behavior described above. That setting will now be false by default ...

Which (as for me) is exactly what I expected when I first start using vscode. So how can I downvote that decision? Even the name itself Preferences: Open Settings (JSON) hints me a json file should be opened with no more magic. More than that, the "workbench.settings.openDefaultKeybindings": false also helps me along this way to "unify" my experience.

I didn't find any mention of actual removing split JSON view. It just moved or not set by default, or something else.. If I understood correctly the workbench.settings.useSplitJSON should give you old behaviour back.

@vscodebot vscodebot bot locked and limited conversation to collaborators Jan 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
keybindings-editor Keybinding editor issues
Projects
None yet
Development

No branches or pull requests

4 participants