Suggestion trigger characters not inserted

[mjbvz]

Issue Type: Bug

Repo

1. In a js file
2. Type consol
3. Press . to accept console suggestion

Bug
Only console inserted. The . is dropped

VS Code version: code-oss-dev 1.30.0 (Commit unknown, Date unknown)
OS version: Darwin x64 18.2.0

System Info

Item	Value
CPUs	Intel(R) Core(TM) i7-4770HQ CPU @ 2.20GHz (8 x 2200)
GPU Status	2d_canvas: enabled checker_imaging: disabled_off flash_3d: enabled flash_stage3d: enabled flash_stage3d_baseline: enabled gpu_compositing: enabled multiple_raster_threads: enabled_on native_gpu_memory_buffers: enabled rasterization: enabled video_decode: enabled video_encode: enabled webgl: enabled webgl2: enabled
Load (avg)	3, 3, 2
Memory (System)	16.00GB (0.34GB free)
Process Argv	.
Screen Reader	no
VM	25%

[mjbvz]

Result of of c2c2e48 I think. Looks like a race:

• If I get rid of the await in _onDidSelectItem, it works.
• Not related to the resolve itself. If I change the await to await new Promise(resolve => setTimeout(resolve, 0));, it also doesn't work

[mjbvz]

@jrieken I'm reverting c2c2e48 so that it does not hit insiders. Still looking into fix

[mjbvz]

Sorry @jrieken, I took a look but am not sure how about this one. c2c2e48 would be nice to have but is not a regression so it's not essential for November

[jrieken]

Fair enough - making the insert-call async was a bold move ;-). Moving this to December for a proper fix

[mjbvz]

Potential related: #42544 Support suppressing commit character from being inserted during completion

[jrieken]

Closing this in favour of #73311 and/or #63013. Both have the same root cause which is us not always resolving completions before inserting...