Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multi debug console feature is not aligned with integrated and external terminals #62420

Closed
weinand opened this issue Nov 1, 2018 · 2 comments
Assignees
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues
Milestone

Comments

@weinand
Copy link
Contributor

weinand commented Nov 1, 2018

  • run cluster sample

Observe: every process gets its own debug console

  • set "console" attribute to "integrated terminal"
  • run cluster sample again

Observe: all processes run in a single terminal

We should consider to represent the multi debug console feature as a new console type "multi console".

@weinand weinand added debug Debug viewlet, configurations, breakpoints, adapter issues debug-console labels Nov 1, 2018
@weinand weinand changed the title multi debug consoles is not aligned with integrated and external terminals multi debug console feature is not aligned with integrated and external terminals Nov 1, 2018
@isidorn
Copy link
Contributor

isidorn commented Nov 2, 2018

Currently the console field is contributed by the node debug adapter, vscode is not aware of this.
So I would suggest that this one we solve on the node debug side piggy backing on #62419
So after we add that flag the node debug adapter would turn on that flag if the console attribute is not internalConsole.

@isidorn
Copy link
Contributor

isidorn commented Nov 12, 2018

After discussion we have decided to solve this by tackling it from the cluster sample perspective.
In a case that autoAttachToChildProcess is enabled the node debug would automatically switch the console option to use the integrated terminal
Forwarding to @weinand

Seperate from this we will tackle #62419 once we get more user feedback

@isidorn isidorn assigned weinand and unassigned isidorn Nov 12, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Dec 29, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues
Projects
None yet
Development

No branches or pull requests

2 participants