Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

editor.acceptSuggestionOnEnter: "off" not working in debugging console #60877

Closed
maple3142 opened this issue Oct 14, 2018 · 17 comments
Closed

editor.acceptSuggestionOnEnter: "off" not working in debugging console #60877

maple3142 opened this issue Oct 14, 2018 · 17 comments
Assignees
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues feature-request Request for new features or functionality
Milestone

Comments

@maple3142
Copy link

Issue Type: Bug

editor.acceptSuggestionOnEnter: "off" doesn't work when I type in debugging console.
It still insert FileList when I type files and hit enter.
Video: https://streamable.com/r7zcc

VS Code version: Code 1.28.1 (3368db6, 2018-10-11T18:15:15.139Z)
OS version: Windows_NT ia32 10.0.17134

System Info
Item Value
CPUs Intel(R) Core(TM) i5-6500 CPU @ 3.20GHz (4 x 3192)
GPU Status 2d_canvas: enabled
checker_imaging: disabled_off
flash_3d: enabled
flash_stage3d: enabled
flash_stage3d_baseline: enabled
gpu_compositing: enabled
multiple_raster_threads: enabled_on
native_gpu_memory_buffers: disabled_software
rasterization: enabled
video_decode: enabled
video_encode: enabled
webgl: enabled
webgl2: enabled
Memory (System) 15.96GB (8.37GB free)
Process Argv ffmpeg.js.wasm|
Screen Reader no
VM 0%
Extensions (47)
Extension Author (truncated) Version
vscode-css-formatter aes 1.0.1
markdown-checkbox bie 0.1.1
better-toml bun 0.3.2
npm-intellisense chr 1.3.0
gitignore cod 0.5.0
vscode-svgviewer css 1.4.7
vscode-markdownlint Dav 0.20.0
vscode-eslint dba 1.6.0
xml Dot 2.3.2
EditorConfig Edi 0.12.5
tslint eg2 1.0.40
vscode-npm-script eg2 0.3.5
prettier-vscode esb 1.6.1
vsc-travis-ci-status fel 1.1.0
code-runner for 0.9.4
terminal for 0.0.10
vscode-yarn gam 1.6.0
vscode-pull-request-github Git 0.2.1
webpack-snippets gog 0.0.4
vue-snippets hol 0.1.9
minify Hoo 0.3.0
webpack jer 2.1.0
nearley kar 1.0.3
vscode-fix-checksums leh 1.1.0
g-translate map 0.0.2
dotenv mik 1.0.1
theme-monokai-pro-vscode mon 1.1.8
vscode-attrs-sorter mrm 2.1.0
vscode-jade-snippets mrm 1.0.1
vscode-language-pack-zh-hant MS- 1.28.2
python ms- 2018.9.0
cpptools ms- 0.19.0
debugger-for-chrome msj 4.10.2
vetur oct 0.13.0
material-icon-theme PKi 3.6.0
polacode pnp 0.2.2
vscode-graphql Pri 0.1.5
ejs-language-support Qas 0.0.1
vscode-yaml red 0.0.17
LiveServer rit 5.1.1
background sha 1.1.19
code-settings-sync Sha 3.1.2
language-stylus sys 1.10.0
nativescript-xml-snippets tsv 1.0.7
quokka-vscode Wal 1.0.153
swig zhu 0.0.5
vscode-open-in-github ziy 1.3.6
@vscodebot
Copy link

vscodebot bot commented Oct 14, 2018

(Experimental duplicate detection)
Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

@isidorn
Copy link
Contributor

isidorn commented Oct 15, 2018

I acknowledge the limiation.
The issue here is that we manually set acceptSuggestionOnEnter: "smart" for the debug console so that when the user inputs the whole match and presses enter it would get immediatly evaluated.

Leaving this open as a feature request.

@isidorn isidorn added feature-request Request for new features or functionality debug Debug viewlet, configurations, breakpoints, adapter issues debug-console and removed new release labels Oct 15, 2018
@isidorn isidorn added this to the Backlog milestone Oct 15, 2018
@isidorn isidorn removed their assignment Oct 15, 2018
@sebnapi
Copy link

sebnapi commented Nov 8, 2018

THIS IS SO ANNOYING!

this Enter -> TouchList

@johan-boule
Copy link

On a side note, i find the mere existence of the 'enter' shortcut for autocompletion to be a misfeature. There's 'tab' for that. I suppose removing the shortcut altogether is the "solution".

@vscodebot
Copy link

vscodebot bot commented Oct 8, 2019

This issue is being closed to keep the number of issues in our inbox on a manageable level, we are closing issues that are not going to be addressed in the foreseeable future: We look at the number of votes the issue has received and the number of duplicate issues filed. More details here. If you disagree and feel that this issue is crucial: We are happy to listen and to reconsider.

If you wonder what we are up to, please see our roadmap and issue reporting guidelines.

Thanks for your understanding and happy coding!

@vscodebot vscodebot bot closed this as completed Oct 8, 2019
@ghost
Copy link

ghost commented May 11, 2020

This problem is very annoying. I have to press "space backspace enter" to skip autocomplete instead of just an "enter" to execute a single command. It makes debug console almost unusable. Please fix this bug.

@andrewlstewart
Copy link

This is an incredibly frustrating feature of an otherwise great IDE.

@ivanhernandez13
Copy link

Is this FR still a possibility? From the duped issue above looks like there was an intention to reopen this bug.

@isidorn
Copy link
Contributor

isidorn commented Aug 5, 2020

Yes, we can reopen. And we might weclome PRs that tackle this.

@isidorn isidorn reopened this Aug 5, 2020
@isidorn isidorn removed the *out-of-scope Posted issue is not in scope of VS Code label Aug 5, 2020
@damdaepark
Copy link

Is it fixed now? It's really annoying.

@flshfm
Copy link

flshfm commented Dec 2, 2020

Might be a little help until this gets closed: If you change the When Expression of the Keyboards shortcut "Debug:Stop" to "inDebugMode && !inDebugRepl" you can Esc + Enter

This problem is very annoying. I have to press "space backspace enter" to skip autocomplete instead of just an "enter" to execute a single command. It makes debug console almost unusable. Please fix this bug.

@kyle-mallah
Copy link

This is the most annoying thing. there is editor.acceptSuggestionOnEnter, but no terminal.acceptSuggestionOnEnter or related

@joshenders
Copy link

joshenders commented Dec 9, 2020

Also experiencing this issue. This is quite problematic as others have mentioned because debugging now involves cancelling the autosuggestion by striking the escape key before interacting. It's a very frustrating experience.

@bersbersbers
Copy link

Related: #108439

@ell1e
Copy link

ell1e commented Jan 29, 2021

There is debug.console.historySuggestions but for me it doesn't work: #110838

Also, as I explained here I think not only are working options needed for all these enter-autocompletes scenarios but also the default should be changed throughout the IDE: #108536 (to have enter auto-completing default to off everywhere, both editor and terminal)

I think the whole situation around auto-complete settings needs an entire rethink. I spend an entire day trying to turn everything off because it's spread out over multiple settings (and I still use auto complete all the time, just without the very bad enter-autocompletes shortcut which is an absolute nightmare in languages without line terminators like Python) and it's still not fully off due to e.g. this bug/ticket here and maybe me missing more related settings. This should not be my first IDE experience. It is way too hard to get a sane configuration, the defaults need to be better.

@gabrielhuang
Copy link

please fix!!!

@isidorn
Copy link
Contributor

isidorn commented Aug 13, 2021

This is fixed now.
Apart from that we introduced debug.console.acceptSuggestionOnEnter to control this behaviour.

@isidorn isidorn closed this as completed Aug 13, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Sep 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues feature-request Request for new features or functionality
Projects
None yet
Development

No branches or pull requests