-
Notifications
You must be signed in to change notification settings - Fork 29.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make extension ui similar to the settings ui #58726
Comments
I agree. We are not being consistent here. This is available in the Details and Changelog section, but not in the Contributions.
Yes, the style in the settings editor does look modern and much better
It already is sticky. i.e when you scroll the page, the header remains where it is. Are you referring to something else? Some thoughts on re-design:
cc @misolori |
I meant something like https://www.w3schools.com/howto/howto_js_sticky_header.asp where the extension information is separate from the navigation and is hidden when scrolling. |
Ah, that definitely is a good idea |
This should be covered under #68527 so closing this as a duplicate. |
Thanks for creating this issue! We figured it's covering the same as another one we already have. Thus, we closed this one as a duplicate. You can search for existing issues here. See also our issue reporting guidelines. Happy Coding! |
The extension preview doesn't seem as well organized as the new settings preview. Here are my suggestions for improving consistency:
Hide "Scroll Back to Top" button
Is there any telemetry data on how often this button is used? Neither the markdown nor the settings preview show this button, so displaying here doesn't make much sense. Also, I don't think it's themable so it just sits there looking depressed.
Use same nav style
The first image shows how the settings ui styles its nav headers and I personally find it more modern.
Make navbar more condensed
The current navbar is pretty verboose and it covers 1/3 of my screen while I'm reading the details or contributions. Maybe it could benefit from being sticky or even redesigned?
The text was updated successfully, but these errors were encountered: