Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make extension ui similar to the settings ui #58726

Closed
ghost opened this issue Sep 14, 2018 · 5 comments
Closed

Make extension ui similar to the settings ui #58726

ghost opened this issue Sep 14, 2018 · 5 comments
Assignees
Labels
*duplicate Issue identified as a duplicate of another issue(s) extensions Issues concerning extensions under-discussion Issue is under discussion for relevance, priority, approach ux User experience issues
Milestone

Comments

@ghost
Copy link

ghost commented Sep 14, 2018

The extension preview doesn't seem as well organized as the new settings preview. Here are my suggestions for improving consistency:

Hide "Scroll Back to Top" button

Is there any telemetry data on how often this button is used? Neither the markdown nor the settings preview show this button, so displaying here doesn't make much sense. Also, I don't think it's themable so it just sits there looking depressed.

screenshot_20180914_183244

Use same nav style

screenshot_20180914_190225

screenshot_20180914_190301

The first image shows how the settings ui styles its nav headers and I personally find it more modern.

Make navbar more condensed

screenshot_20180914_184019

The current navbar is pretty verboose and it covers 1/3 of my screen while I'm reading the details or contributions. Maybe it could benefit from being sticky or even redesigned?

@vscodebot vscodebot bot added the markdown Markdown support issues label Sep 14, 2018
@mjbvz mjbvz added extensions Issues concerning extensions and removed markdown Markdown support issues labels Sep 17, 2018
@mjbvz mjbvz assigned sandy081 and unassigned mjbvz Sep 17, 2018
@sandy081 sandy081 assigned ramya-rao-a and unassigned sandy081 Sep 18, 2018
@ramya-rao-a ramya-rao-a added the ux User experience issues label Sep 19, 2018
@ramya-rao-a
Copy link
Contributor

Hide "Scroll Back to Top" button

I agree. We are not being consistent here. This is available in the Details and Changelog section, but not in the Contributions.
Another issue is the weird text shown on hover:

image

Use same nav style

Yes, the style in the settings editor does look modern and much better

The current navbar is pretty verboose and it covers 1/3 of my screen while I'm reading the details or contributions. Maybe it could benefit from being sticky or even redesigned?

It already is sticky. i.e when you scroll the page, the header remains where it is. Are you referring to something else?

Some thoughts on re-design:

  • Skip the description line. By default, we show the README for the extension which should have the required details. The description is covered in the list item in the extension viewlet as well, which the user would have read before clicking on the item which then opens the extension editor
  • Move the Disable/Uninstall buttons to the first line next to the extension name and title

cc @misolori

@ramya-rao-a ramya-rao-a added the under-discussion Issue is under discussion for relevance, priority, approach label Sep 19, 2018
@ramya-rao-a ramya-rao-a added this to the Backlog milestone Sep 19, 2018
@ghost
Copy link
Author

ghost commented Sep 20, 2018

I meant something like https://www.w3schools.com/howto/howto_js_sticky_header.asp where the extension information is separate from the navigation and is hidden when scrolling.

@ramya-rao-a
Copy link
Contributor

Ah, that definitely is a good idea

@ramya-rao-a ramya-rao-a removed their assignment Nov 15, 2018
@miguelsolorio
Copy link
Contributor

This should be covered under #68527 so closing this as a duplicate.

@miguelsolorio miguelsolorio added the *duplicate Issue identified as a duplicate of another issue(s) label Oct 8, 2019
@vscodebot
Copy link

vscodebot bot commented Oct 8, 2019

Thanks for creating this issue! We figured it's covering the same as another one we already have. Thus, we closed this one as a duplicate. You can search for existing issues here. See also our issue reporting guidelines.

Happy Coding!

@vscodebot vscodebot bot closed this as completed Oct 8, 2019
@github-actions github-actions bot locked and limited conversation to collaborators Jun 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*duplicate Issue identified as a duplicate of another issue(s) extensions Issues concerning extensions under-discussion Issue is under discussion for relevance, priority, approach ux User experience issues
Projects
None yet
Development

No branches or pull requests

4 participants