Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Git errors - give me action to show output #5815

Closed
isidorn opened this issue Apr 26, 2016 · 4 comments
Closed

Git errors - give me action to show output #5815

isidorn opened this issue Apr 26, 2016 · 4 comments
Assignees
Labels
feature-request Request for new features or functionality git GIT issues verified Verification succeeded
Milestone

Comments

@isidorn
Copy link
Contributor

isidorn commented Apr 26, 2016

#5766

  1. have a git error
  2. I would like to see an action left of the 'Close' - 'Open Output', that would take me directly to the git ouput - that way the message and the cause would not be so disconected as now

screen shot 2016-04-26 at 13 04 54

@isidorn isidorn added feature-request Request for new features or functionality git GIT issues labels Apr 26, 2016
@joaomoreno joaomoreno added this to the April 2016 milestone Apr 26, 2016
@joaomoreno
Copy link
Member

joaomoreno commented Apr 27, 2016

Can't reproduce, this was implemented long ago. Do you remember which action it was?

image

@isidorn
Copy link
Contributor Author

isidorn commented Apr 27, 2016

Here's how I can always repro:

  1. Open any file in our repo and remove a semicolon on end of line
  2. command pallette > git commit
  3. commit will fail due to lint check and I do not get the show output action

@isidorn isidorn reopened this Apr 27, 2016
@joaomoreno
Copy link
Member

joaomoreno commented Apr 27, 2016

@bpasero This command is a workbench actions which returns an error that has resolution actions. This pattern works when giving this error directly to the message service. Do you know why this is not getting properly wired up all the way to the message service?

@joaomoreno joaomoreno assigned bpasero and unassigned joaomoreno Apr 27, 2016
@bpasero bpasero assigned isidorn and unassigned bpasero Apr 27, 2016
@joaomoreno
Copy link
Member

👍

@isidorn isidorn added the verified Verification succeeded label Apr 29, 2016
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality git GIT issues verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

3 participants