Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings editor: focus navigation not ideal for up / down #57372

Closed
isidorn opened this issue Aug 28, 2018 · 4 comments
Closed

Settings editor: focus navigation not ideal for up / down #57372

isidorn opened this issue Aug 28, 2018 · 4 comments
Assignees
Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues settings-editor VS Code settings editor issues under-discussion Issue is under discussion for relevance, priority, approach

Comments

@isidorn
Copy link
Contributor

isidorn commented Aug 28, 2018

Refs: #57304

If I focus into the settings list and I press down I would expect that every time I press down the next setting is focused. And if I want to inspect the content of that setting I would hit tab to focus into it.
However this is not how it currently behaves, every up / down focuses random elements between settings and this makes the navigation cumbersome as compared to our other lists in vscode.

For instance this works very nicely in the table of contents in the settings.

@isidorn isidorn added accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues settings-editor VS Code settings editor issues labels Aug 28, 2018
@roblourens
Copy link
Member

Settings essentially isn't a list anymore, it used to be but that was very unpopular

@isidorn
Copy link
Contributor Author

isidorn commented Aug 28, 2018

I do not understand how is that connected to my suggestion that up / down should move focus through each element.
What is the downside of that?
Reopening for discussion

@isidorn isidorn reopened this Aug 28, 2018
@isidorn isidorn added the under-discussion Issue is under discussion for relevance, priority, approach label Aug 28, 2018
@roblourens
Copy link
Member

We can't use the arrow keys for navigation because they are used for the input controls. For example, 'down' will open the dropdown control. Is that basically what you're suggesting? You're describing how it worked last month, but we switched to only tab-based navigation, so it's like any other form.

I considered adding commands to focus the next/previous setting control so someone can add their own keybindings like ctrl+up/down but I don't think anyone really wants that, tab is how navigation should work in a form.

@isidorn
Copy link
Contributor Author

isidorn commented Aug 29, 2018

Thanks for the explanation. Ok let's go with tab and wait for user feedback

@isidorn isidorn closed this as completed Aug 29, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Oct 13, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues settings-editor VS Code settings editor issues under-discussion Issue is under discussion for relevance, priority, approach
Projects
None yet
Development

No branches or pull requests

2 participants