-
Notifications
You must be signed in to change notification settings - Fork 29.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved Welcome Screen #56144
Comments
@beastdestroyer Thanks for the write up! PRs would be best, if you want to give it a try. |
Hey @chrmarti Sure I would love to! I haven't contributed to VSCode before, probably will take some time to get used to insert awkward laugh here Also where are the files which contribute to the Welcome screen at? I use the User setup. |
It's all minified in the installs. https://github.com/Microsoft/vscode/wiki/How-to-Contribute will get you running out of source. You can then modify the Welcome page files on disk (there are 4: https://github.com/Microsoft/vscode/tree/master/src/vs/workbench/parts/welcome/page/electron-browser). |
All right, thanks very much! laughs in excitement Time to put my newly learnt TS knowledge to use :) |
@chrmarti Editing is going pretty well, although an unwanted CSS Class |
That is added/removed dynamically based on the height: https://github.com/Microsoft/vscode/blob/504c890ea1cb1d0ad310cf9ed620fc89264c18aa/src/vs/workbench/parts/welcome/walkThrough/electron-browser/walkThroughPart.ts#L207 |
@chrmarti Just curious, how do you get the VSCode logo onto the welcome screen. So far I've just been testing by relatively linking to an OSS img file but it's a bit hard to resize it (I think it was called letterbox or something)
Thanks! |
The background image is set here: https://github.com/Microsoft/vscode/blob/90171dab977e4cea933a01824ed0313d86eccdc8/src/vs/workbench/browser/parts/editor/editorGroupView.ts#L1427 The default icon is replaced with the VS Code icon during our build process. To test what it will look like you could replace the letterpress SVGs in the source with those that you have in your installation folder. |
@beastdestroyer Let us know if you are you working on this. It will make sense to submit PRs early so we can provide feedback. |
Apologies, my build process broke since I had to reinstall VS2017, and then my vscode repo got corrupt so I had to redownload and refork. Also, I have been taking time slowly for school business too. Furthermore it's all just getting used to the code structure. If I don't make it by this month's iteration I'll probably aim for November. Thanks. |
@chrmarti Getting this error after running yarn run watch, then the bat script:
When I have time to work on it I'll investigate further, thanks. |
@beastdestroyer It might be best to first make sure you are starting from a clean repository (careful this will delete files not checked in):
Also check if you have any local changes and stash these to ensure these are not the cause. |
Thanks! It's all working properly now, will work as much as I can to get this going. |
@chrmarti This is an initial test, without any logo because I wish to save finer details for later. There are a few questions I have regarding it:
Thanks, I'll keep working on it |
Why would anybody want scroll on welcome page? The page layout is fine as it is... If you have a lot of energy, can you please make some small improvements to it? Like:
|
I would like to say this is my first time exploring the codebase, but yes I m very optimistic. Thank you for your feedback.
I'll note that.
I done that originally but I remember I had a directory which pointed to a file, unless I am just tripping in which case I rest my point. I'll change it after.
Folder icons stuff is definitely an area I have no experience with. But I'll definitely put StackOverflow and GitHub icons.
I agree with this too, despite the fact I usually disable the Welcome screen
Will add it.
I think that it very doable, I'll experiment with layout too.
No clue why, I think this is the case with the Settings GUI too.
I'll see what I can edit, I suppose this was introduced a while back and hasn't been updated since then.
I tried doing that; it kinda works but I'll have to dig deeper to find the specific styling. |
I'm not from vscode team, so you should ask @chrmarti before implementing any of those items, I just wrote random stuff about welcome page that I don't like. |
Yah I had actually planned to do some of them such as the checkbox, but yes I agree. You might try to open separate issues for some of them too |
@beastdestroyer I think the Welcome page should work without scrolling, its main function is to give an overview of the main features of the product and a few important external resources. I'm also not a fan of making the title / link texts more verbose, they should be short so they are easy to skim through. |
@chrmarti I have been. unable to do much progress due to life being more hectic. Unfortunately I muat unassign myself from this project. Sorry about that. I am still very optimistic for improvements and I hope someone else can take over. Again I apologise, have a great time |
We have since redesigned the welcome page. |
Issue Type: Feature Request/UI
No relevant Issues found.
I believe that as a long-time user of VSCode, the Welcome screen is mere redundant to me, however I feel that for newer users, that the layout doesn't seem that appealing.
I understand that it may not be worth to show on small heights, but I don't think a little scrolling would harm anyone. I believe cramming a bunch of stuff could cause more confusion. The title and subtitle should be placed aligned in the middle, with the VSCode icon (coloured or the non-coloured version, I'm personally split on this and leave it up to you should you consider my suggestion) on top of the text
(maybe text sits on top, overlapping? Again, split).
These blue texts should probably be buttons, or at least have more padding and either an underline, or if you go the button route, contain the main button with the main text, and the extra text outside it perhaps.
Even I know I didn't explain it clearly enough, and would be happy to provide a HTML/CSS Mockup of what I mean, please let me know if so!
TODO List:
The text was updated successfully, but these errors were encountered: