Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'Tokenization is skipped for lines longer than 20k characters for performance reasons ' showing when auto-suggest box shows #55212

Closed
jpike88 opened this issue Jul 27, 2018 · 2 comments
Assignees
Labels
editor-hover Editor mouse hover tokenization Text tokenization typescript Typescript support issues upstream Issue identified as 'upstream' component related (exists outside of VS Code)

Comments

@jpike88
Copy link

jpike88 commented Jul 27, 2018

  • VSCode Version: Latest
  • OS Version: macOS High Sierra

Steps to Reproduce:

  1. Import a JSON with loads of keys (the JSON is not minified and is beautified), and have a method require a parameter that uses keyof typeof on that imported JSON object. Effectively, it becomes a large amount of string values all joined by the OR operator.

  2. Hold CMD over a call on that method, which brings up the more info tooltip.

'Tokenization is skipped for lines longer than 20k characters for performance reasons' shows in a warning tooltip.

I shouldn't have to see that.

screen shot 2018-07-27 at 1 21 36 pm

SOLUTION: truncate the grey information text to an amount of characters below 20k.

Does this issue occur when all extensions are disabled?: Yes

@vscodebot vscodebot bot added editor editor-contrib Editor collection of extras labels Jul 27, 2018
@kieferrm kieferrm added tokenization Text tokenization and removed editor editor-contrib Editor collection of extras labels Jul 27, 2018
@jpike88
Copy link
Author

jpike88 commented Aug 21, 2018

@alexandrudima any luck on this one? Seems like a quick fix doesn't it?

@alexdima alexdima added typescript Typescript support issues editor-hover Editor mouse hover labels Aug 21, 2018
@microsoft microsoft deleted a comment from vscodebot bot Aug 21, 2018
@mjbvz
Copy link
Collaborator

mjbvz commented Aug 21, 2018

Falls under microsoft/TypeScript#14662. We shouldn't return the complete list of values large union cases like this

Closing as upstream

@mjbvz mjbvz closed this as completed Aug 21, 2018
@mjbvz mjbvz added the upstream Issue identified as 'upstream' component related (exists outside of VS Code) label Aug 21, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Oct 5, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
editor-hover Editor mouse hover tokenization Text tokenization typescript Typescript support issues upstream Issue identified as 'upstream' component related (exists outside of VS Code)
Projects
None yet
Development

No branches or pull requests

4 participants