Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visual Code does not show TS errors in Problem panel if I stopped a tsc build in watch mode and restart it #53783

Closed
ajayindfw opened this issue Jul 7, 2018 · 3 comments
Assignees
Labels
typescript Typescript support issues upstream Issue identified as 'upstream' component related (exists outside of VS Code)
Milestone

Comments

@ajayindfw
Copy link

ajayindfw commented Jul 7, 2018

Here's the scenario:

I open a Visual Studio code project and start up the build task using "Run Build Task" menu in Visual Code. I havae a tasks.json file in the root of my TS project which looks like:

{
    // See https://go.microsoft.com/fwlink/?LinkId=733558
    // for the documentation about the tasks.json format
    "version": "2.0.0",
    "tasks": [
        {
            "type": "typescript",
            "tsconfig": "app/tsconfig.json",
            "option": "watch",
            "problemMatcher": [
                "$tsc-watch"
            ]
        }
    ]
}

the project also has a base tsconfig.base.json that tsconfig.json in apps/ refers to:

{
  "compilerOptions": {
    "target": "es5",                         
   "sourceMap": true,
  "noImplicitAny": true,
    "watch": true ,
    "outDir": "js",
    "strictNullChecks": true
  }
}

The build runs just fine in watch mode when I run the build after opening the IDE. Any TS errors show up both in the Terminal Window and are also reported in the Problems panel. However, if say I make a change to a compiler option in base tsconfig.base.json and restart the build, any errors are not reported in the problems panel.

@vscodebot vscodebot bot added the tasks Task system issues label Jul 7, 2018
@dbaeumer
Copy link
Member

This works for me if I terminate the watch task and restart it.

However I noticed that the interal compiler (TypeScript extension) doesn't reflect the changes.

@dbaeumer
Copy link
Member

@mattbierner assigning to you. Not sure if this needs to be forwarded to TS.

@dbaeumer dbaeumer added typescript Typescript support issues and removed tasks Task system issues labels Jul 10, 2018
@dbaeumer dbaeumer assigned mjbvz and unassigned dbaeumer Jul 10, 2018
@mjbvz mjbvz added the bug Issue identified by VS Code Team member as probable bug label Sep 18, 2018
@mjbvz mjbvz added this to the March 2019 milestone Feb 22, 2019
@mjbvz mjbvz modified the milestones: March 2019, April 2019 Mar 25, 2019
@mjbvz
Copy link
Collaborator

mjbvz commented May 1, 2019

Looks like the original issue with the build tasks works.

microsoft/TypeScript#17753 tracks the issue where you have to save the child tsconfig for changes to the base to be picked up

@mjbvz mjbvz closed this as completed May 1, 2019
@mjbvz mjbvz added upstream Issue identified as 'upstream' component related (exists outside of VS Code) and removed bug Issue identified by VS Code Team member as probable bug labels May 1, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Jun 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
typescript Typescript support issues upstream Issue identified as 'upstream' component related (exists outside of VS Code)
Projects
None yet
Development

No branches or pull requests

3 participants