Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"editorUnnecessaryCode.border" not working #53103

Closed
chrmarti opened this issue Jun 27, 2018 · 1 comment
Closed

"editorUnnecessaryCode.border" not working #53103

chrmarti opened this issue Jun 27, 2018 · 1 comment
Assignees
Labels
*as-designed Described behavior is as designed languages-diagnostics Source problems reporting

Comments

@chrmarti
Copy link
Collaborator

Issue Type: Bug

Testing #52218

It doesn't show as border:
image

In other cases it doesn't show at all:
image

VS Code version: Code - Insiders 1.25.0-insider (f2fa6be, 2018-06-27T05:11:02.122Z)
OS version: Darwin x64 17.6.0

System Info
Item Value
CPUs Intel(R) Core(TM) i7-4770HQ CPU @ 2.20GHz (8 x 2200)
GPU Status 2d_canvas: enabled
flash_3d: enabled
flash_stage3d: enabled
flash_stage3d_baseline: enabled
gpu_compositing: enabled
multiple_raster_threads: enabled_on
native_gpu_memory_buffers: enabled
rasterization: enabled
video_decode: enabled
video_encode: enabled
vpx_decode: enabled
webgl: enabled
webgl2: enabled
Load (avg) 3, 3, 3
Memory (System) 16.00GB (0.73GB free)
Process Argv /Applications/Visual Studio Code - Insiders.app/Contents/MacOS/Electron --extensions-dir /Users/chrmarti/Development/repos/tmp/ext --user-data-dir /Users/chrmarti/Development/repos/tmp/user
Screen Reader no
VM 20%
Extensions: none
@chrmarti chrmarti added the languages-diagnostics Source problems reporting label Jun 27, 2018
@jrieken jrieken removed their assignment Jun 27, 2018
@mjbvz
Copy link
Collaborator

mjbvz commented Sep 7, 2018

In the first example, I believe it is showing as expected. The green dashes are the border

In the second example, we don't show the additional border because the squiggly already exists. We only show editorUnnecessaryCode.border if there no other marker

@mjbvz mjbvz closed this as completed Sep 7, 2018
@mjbvz mjbvz added the *as-designed Described behavior is as designed label Sep 7, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Oct 23, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*as-designed Described behavior is as designed languages-diagnostics Source problems reporting
Projects
None yet
Development

No branches or pull requests

3 participants