Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Connect the sash in the 2x2 grid #50770

Closed
aeschli opened this issue May 30, 2018 · 3 comments
Closed

Connect the sash in the 2x2 grid #50770

aeschli opened this issue May 30, 2018 · 3 comments
Assignees
@joaomoreno
Labels
feature-request Request for new features or functionality on-testplan workbench-editor-grid Grid layout issues in the editor area
Milestone
June 2018

Comments

@aeschli
Copy link
Contributor

aeschli commented May 30, 2018

Testing #50458

  • open the 'grid 2x2' layout
  • move the horizontal sash: The sash only moves in one side.

It would be great if sash on the other side also moves so that the two sashed stay aligned.
@bpasero bpasero added feature-request Request for new features or functionality workbench-editor-grid Grid layout issues in the editor area labels May 30, 2018
@bpasero
Copy link
Member

bpasero commented May 30, 2018

Depends on the grid widget providing a way for me to build a grid layout where views are connected instead of split. I think for the beginning we could do this as a one-off for the "Grid 2x2" layout.

@joaomoreno joaomoreno added this to the June 2018 milestone May 30, 2018
@bpasero bpasero mentioned this issue Jun 1, 2018
Closed
@joaomoreno
Copy link
Member

Started some work here: https://github.com/Microsoft/vscode/tree/joao/grid2x2

It's, of course, tougher than expected... but I think we can get something nice going.

@joaomoreno
Copy link
Member

Fixed by f9911c7

@bpasero bpasero removed their assignment Jun 14, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Jul 27, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@joaomoreno joaomoreno

Labels
feature-request Request for new features or functionality on-testplan workbench-editor-grid Grid layout issues in the editor area
Projects
None yet
Milestone
June 2018
Development

No branches or pull requests
3 participants
@joaomoreno @bpasero @aeschli