Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workbench.action.focusRightGroup not focusing all editor groups #50694

Closed
Tyriar opened this issue May 29, 2018 · 1 comment
Closed

workbench.action.focusRightGroup not focusing all editor groups #50694

Tyriar opened this issue May 29, 2018 · 1 comment
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug *duplicate Issue identified as a duplicate of another issue(s) workbench-editor-grid Grid layout issues in the editor area
Milestone

Comments

@Tyriar
Copy link
Member

Tyriar commented May 29, 2018

VS Code version: Code - Insiders 1.24.0-insider (41a7c49, 2018-05-29T06:09:34.618Z)
OS version: Windows_NT x64 10.0.16299


#50458

Keybinding:

{ "key": "alt+right",       "command": "workbench.action.focusRightGroup", "when": "editorTextFocus" },

Start state:

image

Pressing alt+right 5 times results in:

  1. Top-right focused
  2. Bottom-left focused
  3. Top-right focused (moves the cursor to a seemingly random position)
  4. Bottom-left focused
  5. Nothing
@Tyriar Tyriar added bug Issue identified by VS Code Team member as probable bug workbench-editor-grid Grid layout issues in the editor area labels May 29, 2018
@vscodebot vscodebot bot added the insiders label May 29, 2018
@bpasero bpasero added this to the May 2018 milestone May 30, 2018
@bpasero
Copy link
Member

bpasero commented May 30, 2018

Treating as duplicate of #50679. I would not expect the focus to change once you are on the right hand side of the grid and continue to invoke this action. The fix is to implement these commands within the grid widget.

@bpasero bpasero closed this as completed May 30, 2018
@bpasero bpasero added the *duplicate Issue identified as a duplicate of another issue(s) label May 30, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Jul 14, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug *duplicate Issue identified as a duplicate of another issue(s) workbench-editor-grid Grid layout issues in the editor area
Projects
None yet
Development

No branches or pull requests

2 participants