Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'Move editor in right group' command is confusing #50664

Closed
aeschli opened this issue May 29, 2018 · 4 comments
Closed

'Move editor in right group' command is confusing #50664

aeschli opened this issue May 29, 2018 · 4 comments
Assignees
Labels
workbench-editor-grid Grid layout issues in the editor area

Comments

@aeschli
Copy link
Contributor

aeschli commented May 29, 2018

Testing #50458

  • pick the 'three rows' layout
  • open some editors in each group
  • Use the 'Move editor in right group' command

There's no right group here, so maybe better: 'Move editor in next group'

@aeschli
Copy link
Contributor Author

aeschli commented May 29, 2018

Hm, there's already a command 'Move editor in next group'...

@bpasero
Copy link
Member

bpasero commented May 29, 2018

@aeschli do you mean this command:

image

?

The idea is to move the currently active editor into the editor group to the right if there is one.

@bpasero bpasero added info-needed Issue requires more information from poster workbench-editor-grid Grid layout issues in the editor area labels May 29, 2018
@aeschli
Copy link
Contributor Author

aeschli commented May 30, 2018

@bpasero Yes, that command.
When using that command in 'three rows' layout will move the editor one group below.
So I guess it should do nothing if there isn't a right group, or maybe better create a group on the right.

@aeschli aeschli removed the info-needed Issue requires more information from poster label May 30, 2018
@bpasero
Copy link
Member

bpasero commented May 30, 2018

@aeschli yes it should not do anything if there is no group to the right. This relies on the grid widget giving me the right neighbour groups which is currently broken. We have bugs to track that, so I will close this as duplicate of #50679 which shares the same underlying issue.

@bpasero bpasero closed this as completed May 30, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Jul 14, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
workbench-editor-grid Grid layout issues in the editor area
Projects
None yet
Development

No branches or pull requests

2 participants